search

NERC-CEH / irecord-butterflies-app

Repository for the code for the iRecord Butterflies App
0 stars 0 forks source link

Update likelihood filters within app #69

Closed DavidRoy closed 3 years ago

DavidRoy commented 3 years ago

Using latest BNM dataset

Replace 'old' versions in the app

Small task for KK

RichardFoxBC commented 3 years ago

Use BNM data for 2005-2019 for new rules about what is in your 10km squares

DavidRoy commented 3 years ago

@RichardFoxBC to provide example issues to check, e.g. Dingy Skipper missing from lists @DavidRoy to supply updated geographic filter file to @kazlauskis by 5th July at latest Time filters to be updated at later date

RichardFoxBC commented 3 years ago

Issues from testing the new geographic probabilities supplied by @DavidRoy Dingy Skipper missing from ST60 White Admiral should be included in flying now lists for this week, I would have thought e.g. in SX86. Surprised that Small Heath also not listed as flying now in SX86. There were plenty around at a local site on Saturday (26 June).

RichardFoxBC commented 3 years ago

I was surprised to find at the weekend that Silver-washed Fritillary appeared in the "Species not recorded from your area" list in the beta version of the app. I am in SX86 and there are plenty of BNM records in our 2005-2019 date period in this square. Please can you investigate why it is not appearing in one of the "in your area" lists?

kazlauskis commented 3 years ago

I'll look into this.

kazlauskis commented 3 years ago

I have found 4 species that have cut-off IDs in the probability docs:

SmallPearlBorderedFri
SilverWashedFritillar
PearlBorderedFritilla
QueenOfSpainFritillar

I have corrected these now but it would be good to fix the probability data (weekly and geospacial) scripts to not trim the IDs and keep these full length @DavidRoy

The IDs here aren't new to this Beta update and so this issue is in the public app. The fix should come out when we release the Beta.

@RichardFoxBC Also, what is the correct name of the Polyommatus coridon - Chalkhill Blue or Chalk Hill Blue?

DavidRoy commented 3 years ago

Well done on finding this. These short-hand names came from the old app but I agree that truncated names are not helpful. I'll include the IDs in future versions

RichardFoxBC commented 3 years ago

Is it the truncated names then that is causing these species to be put into the wrong lists in the app?

Polyommatus coridon is Chalk Hill Blue

kazlauskis commented 3 years ago

Is it the truncated names then that is causing these species to be put into the wrong lists in the app?

Yes. I didn't see that some species didn't have the full IDs when developing the app. In the old app there might have been some extra mapping added or similar.

@DavidRoy would it be possible to use ChalkHillBlue instead of ChalkhillBlue in the probability files? This would help me to keep the lookup code consistent across all the species.

RichardFoxBC commented 3 years ago

That's good then. Another problem removed!