NERC-CEH / npms-app

📱NPMS mobile application
http://www.npms.org.uk/
GNU General Public License v3.0
0 stars 0 forks source link

Users could use existing plots in a square without being approved (through app) #37

Closed sacrevert closed 5 years ago

sacrevert commented 7 years ago

Hi,

Yes actually you would be right that indeed it wouldn't be urgent given that. I didn't think about not being able to create the plot in the app

It wouldn't be the case that there would "no way", but it would probably require a more complex scenario than what you suggested The most obvious one I can think of is if someone allocates themselves a square that has already been in use and was de-allocated from a previous user so already has plots. In that case I believe they would be immediately able to use the plots made by the other person even when the square hadn't been approve yet.

To be honest I think it would be mind bending for us to go through all the scenarios, I already did that designing the report. Obviously at the time of testing those scenarios the app didn't exist

I think for now perhaps it would be simply sufficient to note the limitation probably exists but might require more complex scenarios to trigger it. (Noting also that my theory hasn't actually been tested)

Andy

sacrevert commented 5 years ago

@andrewvanbreda can this be closed Andy?