Fixture properties don't reflect the values for the fixture

NERDDISCO / luminave

Operate all the lights with your web browser and create stunning visual experiences.

MIT License

76 stars 8 forks source link

Fixture properties don't reflect the values for the fixture #80

Closed TimPietrusky closed 5 years ago

TimPietrusky commented 5 years ago

Issue description

When editing the properties using the fixture-detail-view.js view, the properties are not reset when switching to another fixture.

Steps to reproduce

Open /fixture
Edit fixture A
Change the dimmer to 50
Go back to /fixture
Edit fixture B
See that dimmer is 50

Versions

Browser: Chrome 69
luminave: 3.0.0

TimPietrusky commented 5 years ago

This was fixed by correctly handling the way the properties are passed from the parent-component (fixture-detail-view) to it's children by connecting the parent to the store and listening to changes. Also we used hasChanged to only re-render when the value actually changed, rather than on every state-change.