NERDDISCO / luminave

Operate all the lights with your web browser and create stunning visual experiences.
MIT License
76 stars 8 forks source link

Remove animation doesn't remove it from scene #85

Closed TimPietrusky closed 4 years ago

TimPietrusky commented 5 years ago

Issue description

When removing an animation that is part of a scene, the animation is not removed from the animation. Instead when removing the animation the following errors are thrown:

timeline-animation

    // Cannot read property 'keyframes' of undefined

    if (changedProperties.has('animation')) {
      this.timeline = this.computeTimeline(this.animation.keyframes);
    }

animation-list-item

// Cannot read property 'name' of undefined

    return html`
      <div>
        ${animation.name}
      </div>
    `;

Steps to reproduce

Versions

  1. Browser: Chrome 69
  2. luminave: 3.0.0
TimPietrusky commented 4 years ago

:tada: This issue has been resolved in version 3.6.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

TimPietrusky commented 4 years ago

:tada: This issue has been resolved in version 3.6.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: