Timeline should be fixture property agnostic and not just fixture

NERDDISCO / luminave

Operate all the lights with your web browser and create stunning visual experiences.

MIT License

76 stars 8 forks source link

Timeline should be fixture property agnostic and not just fixture #95

Closed TimPietrusky closed 5 years ago

TimPietrusky commented 5 years ago

Instead of checking just the fixture in the timeline, it should also be checked if the current property is actually set on the device from the current animation / scene point of view, and not based on every property the fixture might have.

Example

Setting the dimmer for fixture A using a scene A
Setting the modVcolor for fixture A using scene B
Run both scenes
Then just run scene A -> Color is still there, even when the property is not used anymore

TimPietrusky commented 5 years ago

We are still not checking if all properties are currently set on the current animation, but we fixed the problem in the Example.

If there is any other problem related to this, we should open the issue again.