NERSC / buildtest-nersc

MIT License
8 stars 16 forks source link

should we disable failed pipeline notification #174

Closed shahzebsiddiqui closed 1 year ago

shahzebsiddiqui commented 1 year ago

@wspear @jscook2345 @etpalmer63 @prathmesh4321

currently, we have notification whenever pipelines fail. Almost all of these failures are coming from failures due to lack of runner availability instead of actual test failures in the CI pipeline. These are all scheduled pipelines so we will keep getting these notifications whenever job is run.

Screen Shot 2023-04-25 at 10 26 20 AM

If we disable notification on pipeline failure we won't know when the test fails atleast on slack. The benefit of removing this notification is that this won't clutter the chat space with bot notification and we can use it for communication.

The integration is setup in https://software.nersc.gov/NERSC/buildtest-nersc/-/settings/integrations/slack/edit

Currently we have this checked. If i un-check this we should not see these notifications Screen Shot 2023-04-25 at 10 29 21 AM

The integration is setup to notify on open PRs and issues creation which I think is pretty useful

Screen Shot 2023-04-25 at 10 30 37 AM

Please let me know if you agree or disagree with this proposal. You can comment or use 👍 or 👎.

shahzebsiddiqui commented 1 year ago

okay i disabled the slack notification for failed pipeline notification this should not be coming anymore