search

NERSC / buildtest-nersc

MIT License
8 stars 16 forks source link

remove all E4S Testsuite tests that use spack test #237

Closed shahzebsiddiqui closed 9 months ago

shahzebsiddiqui commented 10 months ago

@wspear i think we should remove any tests from E4S Testsuite tests in https://github.com/buildtesters/buildtest-nersc/tree/devel/buildspecs/e4s/E4S-Testsuite/perlmutter/22.11 that use spack test.

I ran a grep command on master branch of testsuite repo and i found the following tests. For instance we should not test adios2 test that is set in https://github.com/buildtesters/buildtest-nersc/blob/devel/buildspecs/e4s/E4S-Testsuite/perlmutter/22.11/adios2.yml rather this should test via spack which we can generate from the template script. 

siddiq90@login40> grep spackTestRun -iR validation_tests/
validation_tests/darshan-util/run.sh:spackTestRun $E4S_SPACK_TEST_HASH
validation_tests/darshan-runtime/run.sh:spackTestRun $E4S_SPACK_TEST_HASH
validation_tests/gasnet/run.sh:spackTestRun $GASNET_HASH
validation_tests/warpx/run.sh:spackTestRun $E4S_SPACK_TEST_HASH
validation_tests/pumi/run.sh:spackTestRun $E4S_SPACK_TEST_HASH
validation_tests/gptune/run.sh:spackTestRun $E4S_SPACK_TEST_HASH
grep: validation_tests/vtk-m/vtk-m: Too many levels of symbolic links
validation_tests/vtk-m/run.sh:spackTestRun $VTK_M_HASH
grep: validation_tests/vtk-m/vtk-m-cuda: Too many levels of symbolic links
validation_tests/superlu-dist/run.sh:spackTestRun ${SUPERLU_DIST_HASH}
validation_tests/hdf5/run.sh:spackTestRun $E4S_SPACK_TEST_HASH
validation_tests/amrex/run.sh:spackTestRun $E4S_SPACK_TEST_HASH
validation_tests/heffte/run.sh:spackTestRun $HEFFTE_HASH
validation_tests/nrm/run.sh:spackTestRun $E4S_SPACK_TEST_HASH
validation_tests/sundials/run.sh:spackTestRun $SUNDIALS_HASH
validation_tests/openpmd-api/run.sh:spackTestRun $E4S_SPACK_TEST_HASH
validation_tests/adios2/run.sh:spackTestRun "${ADIOS2_HASH}"
validation_tests/bricks/run.sh:spackTestRun $E4S_SPACK_TEST_HASH
validation_tests/tasmanian/run.sh:spackTestRun $TASMANIAN_HASH
grep: validation_tests/vtk-m-cuda/vtk-m: Too many levels of symbolic links
validation_tests/vtk-m-cuda/run.sh:spackTestRun $VTK_M_HASH
grep: validation_tests/vtk-m-cuda/vtk-m-cuda: Too many levels of symbolic links
validation_tests/libpressio/run.sh:spackTestRun $E4S_SPACK_TEST_HASH

We should also update the file https://github.com/buildtesters/buildtest-nersc/blob/devel/buildspecs/e4s/testgen/packages.yaml and only specify packages that have actual tests in this repo. I think the goal is to use E4S Testsuite to run tests that spack doesn't provide.

Let me know if you agree with this approach.