search

NERSC / jupyterlab-slurm

BSD 3-Clause "New" or "Revised" License
92 stars 23 forks source link

README.md fix #17

Closed jhgoebbert closed 5 years ago

jhgoebbert commented 5 years ago

Thanks for the great extension! I just saw this minor things I came across in the README.md: "pip install jupyterlab_slurm"-> ""pip install jupyterlab-slurm" "jupyter serverextension enable --py --sys-prefix dask_labextension" -> "jupyter serverextension enable --py --sys-prefix jupyterlab-slurm"

jhgoebbert commented 5 years ago

"pip install jupyterlab_slurm" is correct, but then PyPi´s webpage is wrong: https://pypi.org/project/jupyterlab-slurm

JonjonHays commented 5 years ago

Thanks for the catch! I'll get that fixed up. And yes, the server extension module is named "jupyterlab_slurm" (needs to be since it is a python package), but PyPi converts it to a hyphen. I haven't actually tried running pip install jupyterlab-slurm, but I think both versions will work (underscore or hyphen) -- I will test it out tonight, and add a note if necessary. Thanks again!