search

NERSC / jupyterlab-slurm

BSD 3-Clause "New" or "Revised" License
92 stars 23 forks source link

More clearly indicate that submitting job via file or file contents are mutually exclusive #30

Closed krinsman closed 2 years ago

krinsman commented 4 years ago

For the batch job submission modal/popup.

twrobinson commented 4 years ago

Hi, as the only available "Query" seems to be the submission of a Slurm batch job, then I would suggest either "Submit Job", "Submit Batch Job", or simply "Submit" (with slight preference for the latter). As the dialogue box allows either a path to a submission script or a means to create one, I wonder if "Or," should be added before "Enter a new batch script". Just so the user knows that you should not be filling in both fields.

twrobinson commented 4 years ago

I noticed that the default behaviour was "Submit" on Chrome and Safari, it was only "Submit Query" on Firefox (at least on Mac OSX). So I suggested "Submit" in #33 to align the three.

krinsman commented 4 years ago

I'll leave this issue open because I agree with you @twrobinson it should say "or" or otherwise more clearly indicate that the options are mutually exclusive. That bothers me too.

tslaton commented 4 years ago

I've addressed this issue by including a dropdown that changes the type of job (file path or text input) that the user is submitting alongside larger refactoring that's pending here

krinsman commented 4 years ago

@tslaton Is there a screenshot of that which can be posted to this thread/issue?

It sounds like you solved this, maybe we should wait until after we merged your refactor into master to officially close this issue though.