NERSC / jupyterlab-slurm

BSD 3-Clause "New" or "Revised" License
92 stars 23 forks source link

Corrupted JupyterLab after installation. #32

Closed krinsman closed 4 years ago

krinsman commented 4 years ago

I've got corrupted jupyterlab after installation.

image

Restarting server and kernels did not help.

I've resolved this issue with reinstallation of jupyterlab (conda install --force-reinstall jupyterlab). However, jupyterlab-slurm extension has disappeared after this.

Originally posted by @wl2776 in https://github.com/NERSC/jupyterlab-slurm/issues/27#issuecomment-528253678

krinsman commented 4 years ago

@wl2776 This is obviously not good. Are you using the newest version of JupyterLab (or at least the JupyterLab package from Conda Forge)?

I am not sure right now what the fix is but it is obviously a breaking issue, thank you for bring it to our attention @wl2776!

Maybe can you post the output of conda list so we can compare environments? What operating system are you running on? (See here for formatting collapsible things)

conda list ``` # Name Version Build Channel appnope 0.1.0 py37_1000 conda-forge attrs 19.1.0 py_0 conda-forge backcall 0.1.0 py_0 conda-forge bleach 3.1.0 py_0 conda-forge bzip2 1.0.8 h01d97ff_1 conda-forge ca-certificates 2019.6.16 hecc5488_0 conda-forge certifi 2019.6.16 py37_1 conda-forge decorator 4.4.0 py_0 conda-forge defusedxml 0.5.0 py_1 conda-forge elasticsearch 7.0.2 pypi_0 pypi entrypoints 0.3 py37_1000 conda-forge invoke 1.2.0 py37_1000 conda-forge ipykernel 5.1.2 py37h5ca1d4c_0 conda-forge ipython 7.8.0 py37h5ca1d4c_0 conda-forge ipython_genutils 0.2.0 py_1 conda-forge jedi 0.15.1 py37_0 conda-forge jinja2 2.10.1 py_0 conda-forge json5 0.8.5 py_0 conda-forge jsonschema 3.0.2 py37_0 conda-forge jupyter_client 5.3.1 py_0 conda-forge jupyter_core 4.4.0 py_0 conda-forge jupyterlab 1.1.3 py_0 conda-forge jupyterlab_server 1.0.6 py_0 conda-forge libcxx 8.0.1 0 conda-forge libcxxabi 8.0.1 0 conda-forge libffi 3.2.1 h6de7cb9_1006 conda-forge libsodium 1.0.17 h01d97ff_0 conda-forge markdown 3.1.1 pypi_0 pypi markupsafe 1.1.1 py37h1de35cc_0 conda-forge mistune 0.8.4 py37h1de35cc_1000 conda-forge nbconvert 5.6.0 py37_1 conda-forge nbformat 4.4.0 py_1 conda-forge nbresuse 0.3.1 pypi_0 pypi ncurses 6.1 h0a44026_1002 conda-forge newrelic 4.20.1.121 pypi_0 pypi nodejs 11.14.0 h6de7cb9_1 conda-forge notebook 6.0.1 py37_0 conda-forge openssl 1.1.1c h01d97ff_0 conda-forge pandoc 2.7.3 0 conda-forge pandocfilters 1.4.2 py_1 conda-forge parso 0.5.1 py_0 conda-forge pexpect 4.7.0 py37_0 conda-forge pickleshare 0.7.5 py37_1000 conda-forge pip 19.2.3 py37_0 conda-forge prometheus_client 0.7.1 py_0 conda-forge prompt_toolkit 2.0.9 py_0 conda-forge psutil 5.6.2 py37h01d97ff_0 conda-forge ptyprocess 0.6.0 py_1001 conda-forge pycurl 7.43.0.3 pypi_0 pypi pygments 2.4.2 py_0 conda-forge pylibmc 1.6.0 pypi_0 pypi pyrsistent 0.15.4 py37h01d97ff_0 conda-forge python 3.7.3 h93065d6_1 conda-forge python-dateutil 2.8.0 py_0 conda-forge pyzmq 18.0.2 py37hee98d25_2 conda-forge readline 8.0 hcfe32e1_0 conda-forge send2trash 1.5.0 py_0 conda-forge setuptools 41.2.0 py37_0 conda-forge six 1.12.0 py37_1000 conda-forge sqlite 3.29.0 hb7d70f7_1 conda-forge statsd 3.3.0 pypi_0 pypi terminado 0.8.2 py37_0 conda-forge testpath 0.4.2 py_1001 conda-forge tk 8.6.9 h2573ce8_1002 conda-forge tornado 5.1.1 pypi_0 pypi traitlets 4.3.2 py37_1000 conda-forge urllib3 1.25.3 pypi_0 pypi wcwidth 0.1.7 py_1 conda-forge webencodings 0.5.1 py_1 conda-forge wheel 0.33.6 py37_0 conda-forge xz 5.2.4 h1de35cc_1001 conda-forge zeromq 4.3.2 h6de7cb9_2 conda-forge zlib 1.2.11 h01d97ff_1006 conda-forge ```

@tslaton This looks exactly like the error we say with JupyterLab-cpustatus, right? Are we sure this is a bug we can fix on our side, or do you think we should open an issue with JupyterLab?

It seems suspicious that the same error would happen independently in two different extensions written in two very different ways if there was no problem with breaking changes to JupyterLab extension API.

I'm not able to reproduce the error on this machine with JupyterLab Slurm, but I got the same error with JupyterLab-cpustatus on Friday on a different machine. I'm not sure what to do about this.

tslaton commented 4 years ago

I'm not 100% sure what is causing this issue, but I was seeing something similar on a branch I made recently before apparently fixing it with this commit. In working on it, it seemed to be that downgrading from React 16.9.0 to 16.8.4 was the fix.

I believe different versions of JupyterLab are built with different versions of React, and this problem might be occurring when the React version used to build JupyterLab and the version used to build the extension are mismatched.

krinsman commented 4 years ago

@wl2776 Can you confirm that you're building from the master git branch of JupyterLab slurm?

Two of the development git branches use React, but master shouldn't be using it.

We want to see whether we can isolate your problem as an issue with React or not.

I use git-prompt.sh to see which branch of the repository I'm in; I find Git nearly unusable without it: https://github.com/git/git/blob/master/contrib/completion/git-prompt.sh#L15

Change your PS1 to call __git_ps1 as

#        command-substitution:
#        Bash: PS1='[\u@\h \W$(__git_ps1 " (%s)")]\$ '
wl2776 commented 4 years ago

@krinsman, yes, I can confirm, that I'm building from the master branch:

$ git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
conda list ```bash $ conda list # packages in environment at /opt/anaconda: # # Name Version Build Channel _libgcc_mutex 0.1 main _pytorch_select 0.2 gpu_0 _tflow_select 2.1.0 gpu absl-py 0.7.1 py37_0 alembic 1.0.11 py_0 arxiv 0.5.1 pypi_0 pypi asn1crypto 0.24.0 py37_0 astor 0.8.0 py37_0 async_generator 1.10 py37h28b3542_0 atomicwrites 1.3.0 py37_1 attrs 19.1.0 py37_1 backcall 0.1.0 py37_0 bash-kernel 0.7.2 pypi_0 pypi blas 1.0 mkl bleach 3.1.0 py37_0 bokeh 1.3.4 py37_0 bzip2 1.0.8 h7b6447c_0 c-ares 1.15.0 h7b6447c_1001 ca-certificates 2019.6.16 hecc5488_0 conda-forge cairo 1.14.12 h8948797_3 catboost 0.16.2 py37_0 conda-forge certifi 2019.6.16 py37_1 conda-forge cffi 1.12.3 py37h2e261b9_0 chardet 3.0.4 py37_1003 click 7.0 pypi_0 pypi cloudpickle 1.2.1 py_0 colorama 0.4.1 pypi_0 pypi conda 4.7.11 py37_0 conda-forge conda-package-handling 1.3.11 py37_0 configurable-http-proxy 1.3.0 0 conda-forge coverage 4.5.3 py37h7b6447c_0 cryptography 2.7 py37h1ba5d50_0 cudatoolkit 10.0.130 0 cudnn 7.6.0 cuda10.0_0 cupti 10.0.130 0 cycler 0.10.0 py37_0 cython 0.29.13 py37he6710b0_0 cytoolz 0.10.0 py37h7b6447c_0 dask-core 2.3.0 py_0 dbus 1.13.6 h746ee38_0 decorator 4.4.0 py37_1 defusedxml 0.6.0 py_0 dill 0.3.0 py37_0 entrypoints 0.3 py37_0 expat 2.2.6 he6710b0_0 fastcache 1.1.0 py37h7b6447c_0 feedparser 5.2.1 pypi_0 pypi ffmpeg 4.0 hcdf2ecd_0 filelock 3.0.12 pypi_0 pypi fontconfig 2.13.0 h9420a91_0 freeglut 3.0.0 hf484d3e_5 freetype 2.9.1 h8a8886c_1 fribidi 1.0.5 h7b6447c_0 funcsigs 1.0.2 pypi_0 pypi gast 0.2.2 py37_0 glib 2.56.2 hd408876_0 gmp 6.1.2 h6c8ec71_1 gmpy2 2.0.8 py37h10f8cd9_2 google-pasta 0.1.7 py_0 graphite2 1.3.13 h23475e2_0 graphviz 2.40.1 h21bd128_2 grpcio 1.16.1 py37hf8bcb03_1 gst-plugins-base 1.14.0 hbbd80ab_1 gstreamer 1.14.0 hb453b48_1 h5py 2.8.0 py37h989c5e5_3 haitaong 1.0 pypi_0 pypi harfbuzz 1.8.8 hffaf4a1_0 hdf5 1.10.2 hba1933b_1 icu 58.2 h9c2bf20_1 idna 2.8 py37_0 imageio 2.5.0 py37_0 importlib_metadata 0.19 py37_0 intel-openmp 2019.4 243 ipykernel 5.1.2 py37h39e3cac_0 ipympl 0.3.3 py_0 ipython 7.8.0 py37h39e3cac_0 ipython_genutils 0.2.0 py37_0 ipywidgets 7.5.1 py_0 jasper 2.0.14 h07fcdf6_1 jedi 0.15.1 py37_0 jinja2 2.10.1 py37_0 joblib 0.13.2 py37_0 jpeg 9b h024ee3a_2 json5 0.8.5 py_0 jsonschema 3.0.2 py37_0 jupyter-conda 2.5.1 pypi_0 pypi jupyter-tensorboard 0.1.10 pypi_0 pypi jupyter_client 5.3.1 py_0 jupyter_contrib_core 0.3.3 py_2 conda-forge jupyter_contrib_nbextensions 0.5.1 py37_0 conda-forge jupyter_core 4.5.0 py_0 jupyter_highlight_selected_word 0.2.0 py37_1000 conda-forge jupyter_latex_envs 1.4.4 py37_1000 conda-forge jupyter_nbextensions_configurator 0.4.1 py37_0 conda-forge jupyterhub 0.9.6 py37_0 jupyterhub-ldap-authenticator 0.3.2 pypi_0 pypi jupyterhub-systemdspawner 0.13 pypi_0 pypi jupyterlab 1.1.1 py_0 conda-forge jupyterlab-git 0.6.1 pypi_0 pypi jupyterlab-latex 1.0.0 pypi_0 pypi jupyterlab-slurm 0.1.1 pypi_0 pypi jupyterlab_server 1.0.0 py_1 keras 2.2.4 0 keras-applications 1.0.8 py_0 keras-base 2.2.4 py37_0 keras-preprocessing 1.1.0 py_1 kiwisolver 1.1.0 py37he6710b0_0 krb5 1.16.1 h173b8e3_7 ldap3 2.6 py_0 libarchive 3.3.3 h5d8350f_5 libcurl 7.65.3 h20c2e04_0 libedit 3.1.20181209 hc058e9b_0 libffi 3.2.1 hd88cf55_4 libgcc-ng 9.1.0 hdf63c60_0 libgfortran-ng 7.3.0 hdf63c60_0 libglu 9.0.0 hf484d3e_1 libopencv 3.4.2 hb342d67_1 libopus 1.3 h7b6447c_0 libpng 1.6.37 hbc83047_0 libprotobuf 3.8.0 hd408876_0 libsodium 1.0.16 h1bed415_0 libssh2 1.8.2 h1ba5d50_0 libstdcxx-ng 9.1.0 hdf63c60_0 libtiff 4.0.10 h2733197_2 libuuid 1.0.3 h1bed415_2 libvpx 1.7.0 h439df22_0 libxcb 1.13 h1bed415_1 libxml2 2.9.9 hea5a465_1 libxslt 1.1.33 h7d1a2b0_0 lmdb 0.97 pypi_0 pypi lxml 4.4.1 py37hefd8a0e_0 lz4 2.1.10 pypi_0 pypi lz4-c 1.8.1.2 h14c3975_0 lzo 2.10 h49e0be7_2 mako 1.0.10 py_0 markdown 3.1.1 py37_0 markupsafe 1.1.1 py37h7b6447c_0 matplotlib 3.1.1 py37h5429711_0 mistune 0.8.4 py37h7b6447c_0 mkl 2019.4 243 mkl-service 2.0.2 py37h7b6447c_0 mkl_fft 1.0.14 py37ha843d7b_0 mkl_random 1.0.2 py37hd81dba3_0 more-itertools 7.2.0 py37_0 mpc 1.1.0 h10f8cd9_1 mpfr 4.0.1 hdf1c602_3 mpmath 1.1.0 py37_0 nb_conda_kernels 2.2.2 py37_0 nbconvert 5.5.0 py_0 nbformat 4.4.0 py37_0 nbresuse 0.3.2 pypi_0 pypi nbstripout 0.3.6 py_0 conda-forge ncurses 6.1 he6710b0_1 networkx 2.3 py_0 ninja 1.9.0 py37hfd86e86_0 nodejs 10.13.0 he6710b0_0 nose 1.3.7 py37_2 notebook 6.0.0 py37_0 numexpr 2.6.9 pypi_0 pypi numpy 1.16.4 py37h7e9f1db_0 numpy-base 1.16.4 py37hde5b4d6_0 olefile 0.46 py37_0 opencv 3.4.2 py37h6fd60c2_1 opencv-python 4.1.0.25 pypi_0 pypi openssl 1.1.1c h516909a_0 conda-forge packaging 19.1 py37_0 pamela 1.0.0 py_0 pandas 0.25.1 py37he6710b0_0 pandoc 2.2.3.2 0 pandocfilters 1.4.2 py37_1 pango 1.42.4 h049681c_0 parso 0.5.1 py_0 patsy 0.5.1 py37_0 pcre 8.43 he6710b0_0 pexpect 4.7.0 py37_0 pickleshare 0.7.5 py37_0 pillow 6.1.0 py37h34e0f95_0 pip 19.2.2 py37_0 pixman 0.38.0 h7b6447c_0 plotly 4.0.0 py_0 pluggy 0.12.0 py_0 prometheus_client 0.7.1 py_0 prompt_toolkit 2.0.9 py37_0 protobuf 3.8.0 py37he6710b0_0 psutil 5.6.3 pypi_0 pypi ptyprocess 0.6.0 py37_0 py 1.8.0 py37_0 py-opencv 3.4.2 py37hb342d67_1 pyarrow 0.14.1 pypi_0 pypi pyasn1 0.4.6 py_0 pycosat 0.6.3 py37h14c3975_0 pycparser 2.19 py37_0 pycurl 7.43.0.3 py37h1ba5d50_0 pydot 1.4.1 py37_0 pygments 2.4.2 py_0 pyopenssl 19.0.0 py37_0 pyparsing 2.4.2 py_0 pyqt 5.9.2 py37h05f1152_2 pyrsistent 0.14.11 py37h7b6447c_0 pysocks 1.7.0 py37_0 pytest 5.0.1 py37_0 pytest-cov 2.7.1 py_0 pytest-faulthandler 2.0.1 py_0 conda-forge pytest-runner 5.1 pypi_0 pypi python 3.7.4 h265db76_1 python-dateutil 2.8.0 py37_0 python-editor 1.0.4 py_0 python-libarchive-c 2.8 py37_13 python-oauth2 1.1.1 py_0 python-picard 0.4 pypi_0 pypi pytorch 1.2.0 cuda100py37h938c94c_0 pytz 2019.2 py_0 pywavelets 1.0.3 py37hdd07704_1 pyyaml 5.1.2 py37h7b6447c_0 pyzmq 18.1.0 py37he6710b0_0 qt 5.9.7 h5867ecd_1 ray 0.7.3 pypi_0 pypi readline 7.0 h7b6447c_5 redis 3.3.5 pypi_0 pypi requests 2.22.0 py37_0 retrying 1.3.3 py37_2 rlgraph 0.5.5 pypi_0 pypi ruamel_yaml 0.15.46 py37h14c3975_0 scikit-image 0.15.0 py37he6710b0_0 scikit-learn 0.21.2 py37hd81dba3_0 scipy 1.3.1 py37h7c811a0_0 seaborn 0.9.0 py37_0 send2trash 1.5.0 py37_0 setuptools 41.0.1 py37_0 sip 4.19.8 py37hf484d3e_0 six 1.12.0 py37_0 sqlalchemy 1.3.7 py37h7b6447c_0 sqlite 3.29.0 h7b6447c_0 statsmodels 0.10.1 py37hdd07704_0 sympy 1.4 py37_0 tensorboard 1.14.0 py37hf484d3e_0 tensorboardx 1.8 py_0 conda-forge tensorflow 1.14.0 gpu_py37h4491b45_0 tensorflow-base 1.14.0 gpu_py37h8d69cac_0 tensorflow-estimator 1.14.0 py_0 tensorflow-gpu 1.14.0 h0d30ee6_0 termcolor 1.1.0 py37_1 terminado 0.8.2 py37_0 testpath 0.4.2 py37_0 thop 0.0.30-1908302010 pypi_0 pypi tk 8.6.8 hbc83047_0 toolz 0.10.0 py_0 torchvision 0.4.0 cuda100py37hecfc37a_0 tornado 6.0.3 py37h7b6447c_0 tqdm 4.32.1 py_0 traitlets 4.3.2 py37_0 typing 3.7.4 pypi_0 pypi urllib3 1.24.2 py37_0 wcwidth 0.1.7 py37_0 webencodings 0.5.1 py37_1 werkzeug 0.15.5 py_0 wheel 0.33.4 py37_0 widgetsnbextension 3.5.1 py37_0 wrapt 1.11.2 py37h7b6447c_0 xz 5.2.4 h14c3975_4 yaml 0.1.7 had09818_2 zeromq 4.3.1 he6710b0_3 zipp 0.5.2 py_0 zlib 1.2.11 h7b6447c_3 zstd 1.3.7 h0b5b093_0 ```
krinsman commented 4 years ago

@wl2776 Sorry if the following seems dodgy, I just want to rule out all other possibilities, so to confirm:

  1. After force reinstalling JupyterLab, so that everything works but there's no JupyterLab-Slurm, once you reinstall JupyterLab-Slurm (and only JupyterLab-Slurm, no other extensions), the error reappears? (I.e. you are able to reproduce the error?)

  2. You have no other JupyterLab extensions installed currently besides JupyterLab-Slurm?

    You can check this by running jupyter labextension list -- posting the output of that would also be helpful. For example:

    jupyter labextension list

    JupyterLab v1.1.3
    Known labextensions:
       app dir: ~/.conda/envs/nbresuse/share/jupyter/lab
        @jupyterlab/hub-extension v1.0.2  enabled  OK
        jupyterlab-slurm v0.1.3  enabled  OK
        jupyterlab-system-monitor v0.4.1  enabled  OK
        jupyterlab-topbar-extension v0.4.0  enabled  OK

Our working theory right now is that when this orange error shows up, it has something to do with how React operates with an XML-like syntax, and so is connected with JupyterLab extensions that have React as a dependency.

However, the fact that the master branch of this extension does not have React as a dependency, and the fact that you are experiencing this issue when using the master branch, suggests that this theory is incorrect. In order to progress further, and brainstorm different theories for what is going wrong, I am asking the above two questions in order to confirm that the theory is incorrect.

wl2776 commented 4 years ago

Hmm... I've reinstalled jupyterlab-slurm. It has successfully reinstalled, and I see no orange errors.

I'm on master branch ```bash ~/jupyterlab-slurm$ git status On branch master Your branch is up to date with 'origin/master'. nothing to commit, working tree clean ```
I run bash script for this ```bash ~/jupyterlab-slurm$ cat ../inst.sh #!/bin/bash PATH=/opt/anaconda/bin:$PATH /opt/anaconda/bin/pip install . /opt/anaconda/bin/jupyter serverextension enable --sys-prefix jupyterlab_slurm /opt/anaconda/bin/jlpm install /opt/anaconda/bin/jlpm run build /opt/anaconda/bin/jupyter labextension install /opt/anaconda/bin/jupyter lab build ```
It still complains about React ```bash ~/jupyterlab-slurm$ sudo ../inst.sh Processing /home/v.eremeev/jupyterlab-slurm Requirement already satisfied: notebook in /opt/anaconda/lib/python3.7/site-packages (from jupyterlab-slurm==0.1.1) (6.0.0) Requirement already satisfied: jupyter-core>=4.4.0 in /opt/anaconda/lib/python3.7/site-packages (from notebook->jupyterlab-slurm==0.1.1) (4.5.0) Requirement already satisfied: jupyter-client>=5.3.1 in /opt/anaconda/lib/python3.7/site-packages (from notebook->jupyterlab-slurm==0.1.1) (5.3.1) Requirement already satisfied: terminado>=0.8.1 in /opt/anaconda/lib/python3.7/site-packages (from notebook->jupyterlab-slurm==0.1.1) (0.8.2) Requirement already satisfied: traitlets>=4.2.1 in /opt/anaconda/lib/python3.7/site-packages (from notebook->jupyterlab-slurm==0.1.1) (4.3.2) Requirement already satisfied: ipython-genutils in /opt/anaconda/lib/python3.7/site-packages (from notebook->jupyterlab-slurm==0.1.1) (0.2.0) Requirement already satisfied: nbformat in /opt/anaconda/lib/python3.7/site-packages (from notebook->jupyterlab-slurm==0.1.1) (4.4.0) Requirement already satisfied: Send2Trash in /opt/anaconda/lib/python3.7/site-packages (from notebook->jupyterlab-slurm==0.1.1) (1.5.0) Requirement already satisfied: nbconvert in /opt/anaconda/lib/python3.7/site-packages (from notebook->jupyterlab-slurm==0.1.1) (5.5.0) Requirement already satisfied: tornado>=5.0 in /opt/anaconda/lib/python3.7/site-packages (from notebook->jupyterlab-slurm==0.1.1) (6.0.3) Requirement already satisfied: jinja2 in /opt/anaconda/lib/python3.7/site-packages (from notebook->jupyterlab-slurm==0.1.1) (2.10.1) Requirement already satisfied: ipykernel in /opt/anaconda/lib/python3.7/site-packages (from notebook->jupyterlab-slurm==0.1.1) (5.1.2) Requirement already satisfied: prometheus-client in /opt/anaconda/lib/python3.7/site-packages (from notebook->jupyterlab-slurm==0.1.1) (0.7.1) Requirement already satisfied: pyzmq>=17 in /opt/anaconda/lib/python3.7/site-packages (from notebook->jupyterlab-slurm==0.1.1) (18.1.0) Requirement already satisfied: python-dateutil>=2.1 in /opt/anaconda/lib/python3.7/site-packages (from jupyter-client>=5.3.1->notebook->jupyterlab-slurm==0.1.1) (2.8.0) Requirement already satisfied: six in /opt/anaconda/lib/python3.7/site-packages (from traitlets>=4.2.1->notebook->jupyterlab-slurm==0.1.1) (1.12.0) Requirement already satisfied: decorator in /opt/anaconda/lib/python3.7/site-packages (from traitlets>=4.2.1->notebook->jupyterlab-slurm==0.1.1) (4.4.0) Requirement already satisfied: jsonschema!=2.5.0,>=2.4 in /opt/anaconda/lib/python3.7/site-packages (from nbformat->notebook->jupyterlab-slurm==0.1.1) (3.0.2) Requirement already satisfied: bleach in /opt/anaconda/lib/python3.7/site-packages (from nbconvert->notebook->jupyterlab-slurm==0.1.1) (3.1.0) Requirement already satisfied: mistune>=0.8.1 in /opt/anaconda/lib/python3.7/site-packages (from nbconvert->notebook->jupyterlab-slurm==0.1.1) (0.8.4) Requirement already satisfied: pandocfilters>=1.4.1 in /opt/anaconda/lib/python3.7/site-packages (from nbconvert->notebook->jupyterlab-slurm==0.1.1) (1.4.2) Requirement already satisfied: pygments in /opt/anaconda/lib/python3.7/site-packages (from nbconvert->notebook->jupyterlab-slurm==0.1.1) (2.4.2) Requirement already satisfied: testpath in /opt/anaconda/lib/python3.7/site-packages (from nbconvert->notebook->jupyterlab-slurm==0.1.1) (0.4.2) Requirement already satisfied: entrypoints>=0.2.2 in /opt/anaconda/lib/python3.7/site-packages (from nbconvert->notebook->jupyterlab-slurm==0.1.1) (0.3) Requirement already satisfied: defusedxml in /opt/anaconda/lib/python3.7/site-packages (from nbconvert->notebook->jupyterlab-slurm==0.1.1) (0.6.0) Requirement already satisfied: MarkupSafe>=0.23 in /opt/anaconda/lib/python3.7/site-packages (from jinja2->notebook->jupyterlab-slurm==0.1.1) (1.1.1) Requirement already satisfied: ipython>=5.0.0 in /opt/anaconda/lib/python3.7/site-packages (from ipykernel->notebook->jupyterlab-slurm==0.1.1) (7.8.0) Requirement already satisfied: pyrsistent>=0.14.0 in /opt/anaconda/lib/python3.7/site-packages (from jsonschema!=2.5.0,>=2.4->nbformat->notebook->jupyterlab-slurm==0.1.1) (0.14.11) Requirement already satisfied: attrs>=17.4.0 in /opt/anaconda/lib/python3.7/site-packages (from jsonschema!=2.5.0,>=2.4->nbformat->notebook->jupyterlab-slurm==0.1.1) (19.1.0) Requirement already satisfied: setuptools in /opt/anaconda/lib/python3.7/site-packages (from jsonschema!=2.5.0,>=2.4->nbformat->notebook->jupyterlab-slurm==0.1.1) (41.0.1) Requirement already satisfied: webencodings in /opt/anaconda/lib/python3.7/site-packages (from bleach->nbconvert->notebook->jupyterlab-slurm==0.1.1) (0.5.1) Requirement already satisfied: jedi>=0.10 in /opt/anaconda/lib/python3.7/site-packages (from ipython>=5.0.0->ipykernel->notebook->jupyterlab-slurm==0.1.1) (0.15.1) Requirement already satisfied: pickleshare in /opt/anaconda/lib/python3.7/site-packages (from ipython>=5.0.0->ipykernel->notebook->jupyterlab-slurm==0.1.1) (0.7.5) Requirement already satisfied: prompt-toolkit<2.1.0,>=2.0.0 in /opt/anaconda/lib/python3.7/site-packages (from ipython>=5.0.0->ipykernel->notebook->jupyterlab-slurm==0.1.1) (2.0.9) Requirement already satisfied: pexpect; sys_platform != "win32" in /opt/anaconda/lib/python3.7/site-packages (from ipython>=5.0.0->ipykernel->notebook->jupyterlab-slurm==0.1.1) (4.7.0) Requirement already satisfied: backcall in /opt/anaconda/lib/python3.7/site-packages (from ipython>=5.0.0->ipykernel->notebook->jupyterlab-slurm==0.1.1) (0.1.0) Requirement already satisfied: parso>=0.5.0 in /opt/anaconda/lib/python3.7/site-packages (from jedi>=0.10->ipython>=5.0.0->ipykernel->notebook->jupyterlab-slurm==0.1.1) (0.5.1) Requirement already satisfied: wcwidth in /opt/anaconda/lib/python3.7/site-packages (from prompt-toolkit<2.1.0,>=2.0.0->ipython>=5.0.0->ipykernel->notebook->jupyterlab-slurm==0.1.1) (0.1.7) Requirement already satisfied: ptyprocess>=0.5 in /opt/anaconda/lib/python3.7/site-packages (from pexpect; sys_platform != "win32"->ipython>=5.0.0->ipykernel->notebook->jupyterlab-slurm==0.1.1) (0.6.0) Building wheels for collected packages: jupyterlab-slurm Building wheel for jupyterlab-slurm (setup.py) ... done Created wheel for jupyterlab-slurm: filename=jupyterlab_slurm-0.1.1-cp37-none-any.whl size=5981 sha256=a24213a7ef823e3829e1fbbe1306d8244974971709e6650294c9ccb982692366 Stored in directory: /home/v.eremeev/.cache/pip/wheels/e9/c5/81/d963b1c4b4c0985b7bf1ab3e6e63edba5efa3513a7433fdec7 Successfully built jupyterlab-slurm Installing collected packages: jupyterlab-slurm Found existing installation: jupyterlab-slurm 0.1.1 Uninstalling jupyterlab-slurm-0.1.1: Successfully uninstalled jupyterlab-slurm-0.1.1 Successfully installed jupyterlab-slurm-0.1.1 Enabling: jupyterlab_slurm - Writing config: /opt/anaconda/etc/jupyter - Validating... jupyterlab_slurm 0.1.1 OK yarn install v1.15.2 [1/4] Resolving packages... success Already up-to-date. Done in 0.23s. yarn run v1.15.2 $ tsc node_modules/@jupyterlab/ui-components/lib/icon/iconregistry.d.ts:1:8 - error TS1192: Module '"/home/v.eremeev/jupyterlab-slurm/node_modules/@types/react/index"' has no default export. 1 import React from 'react'; ~~~~~ node_modules/@jupyterlab/ui-components/lib/icon/interfaces.d.ts:3:8 - error TS1192: Module '"/home/v.eremeev/jupyterlab-slurm/node_modules/@types/react/index"' has no default export. 3 import React from 'react'; ~~~~~ error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. Building jupyterlab assets (build:dev:minimize) [LabBuildApp] JupyterLab 1.1.1 [LabBuildApp] Building in /opt/anaconda/share/jupyter/lab [LabBuildApp] Building jupyterlab assets (build:dev:minimize) ```

I will add more details later after restarting jupyterlab daemon from systemctl. Currently there could be some unsaved notebooks, that could be lost otherwise.

UPDATE I've restarted the whole PC, where Jupyterlab runs. No errors, and jupyterlab-slurm is shown

krinsman commented 4 years ago

This sounds like good news!

To clarify, after restarting, does or doesn't the react error still happen?

React error ``` node_modules/@jupyterlab/ui-components/lib/icon/iconregistry.d.ts:1:8 - error TS1192: Module '"/home/v.eremeev/jupyterlab-slurm/node_modules/@types/react/index"' has no default export. 1 import React from 'react'; ~~~~~ node_modules/@jupyterlab/ui-components/lib/icon/interfaces.d.ts:3:8 - error TS1192: Module '"/home/v.eremeev/jupyterlab-slurm/node_modules/@types/react/index"' has no default export. 3 import React from 'react'; ~~~~~ error Command failed with exit code 1. ```

I thought we fixed something similar with the bug fix suggested by @andreas-h (Thank you again for that!), but I want to double check whether it worked for you too.

To clarify, you are doing git pull origin master first to make sure the most up-to-date version (which includes the patch) is being used?

wl2776 commented 4 years ago

I've pulled from master and reinstalled jupyterlab-slurm once more. This time there were no errors about React, and no corruptions in Jupyterlab GUI

krinsman commented 4 years ago

Awesome! I'll go ahead and close this for now, but feel free to let us know if the error reappears so we can reopen this issue or create a new one!

krinsman commented 4 years ago

Oh yeah @wl2776 I forgot to mention as an update that I uploaded new versions of JupyterLab Slurm both to NPM and PyPI, so hopefully it won't be necessary to install from source any more to get working versions.