Update index.ts - Githubissues

NERSC / jupyterlab-slurm

BSD 3-Clause "New" or "Revised" License

92 stars 22 forks source link

Update index.ts #33

Closed twrobinson closed 5 years ago

twrobinson commented 5 years ago

Adds a value of Submit to the batch job submit buttons. Default appearance on Firefox (68.0.1) is "Submit Query", which is confusing for a user. This PR adds an explicit value of "Submit", so behaviour on Firefox is aligned with the default behaviour on Safari (12.1.2) and Chrome (76.0.3809.132) on Mac OSX, which was "Submit" anyway.

krinsman commented 5 years ago

Oh wow this is really smart! I didn't realize this was such an easy fix!

Leaving this here for my future reference: https://www.w3schools.com/jsref/prop_pushbutton_value.asp

krinsman commented 5 years ago

@twrobinson What is your e-mail? I can add it for you to the AUTHORS file: https://github.com/NERSC/jupyterlab-slurm/blob/master/AUTHORS

Or you can submit another PR adding your e-mail to it. (I'm assuming your name is Tim Robinson based on what twrobinson.github.io says although admittedly I'm not sure.)