NERSC / podman-hpc

Other
34 stars 5 forks source link

use default args for build, enable building on computes #67

Closed lastephey closed 1 year ago

lastephey commented 1 year ago

Addresses https://github.com/NERSC/podman-hpc/issues/66

Basically just removing the two lines that were treaing the build subcommand differently.

I tested on Muller and this appears to give the behavior we want.

stephey@nid001012:/mscratch/sd/s/stephey/containerfiles/test> podman-hpc build -t test:test . --log-level=debug end of output:

DEBU[0000] Called build.PersistentPostRunE(/usr/bin/podman build --root /tmp/75313_hpc/storage --runroot /tmp/75313_hpc --storage-opt additionalimagestore=/mscratch/sd/s/stephey/storage --storage-opt mount_program=/usr/bin/fuse-overlayfs-wrap --storage-opt ignore_chown_errors=true --cgroup-manager cgroupfs --log-level fatal -t test:test . --log-level=debug)

This change should finally allow podman-hpc builds to work on the compute nodes!

stephey@nid001012:/mscratch/sd/s/stephey/containerfiles/test> podman-hpc build -t test:test . --no-cache
STEP 1/2: FROM docker.io/ubuntu:latest
STEP 2/2: WORKDIR /opt
COMMIT test:test
--> 7641ac3a0cc
Successfully tagged localhost/test:test
7641ac3a0ccbd8e606d012f11987da6fd42643380edb1452e76fd2fe8a59f464
stephey@nid001012:/mscratch/sd/s/stephey/containerfiles/test> 
lastephey commented 1 year ago

Ok @danfulton I added a custom build args config rather than just re-using the default args for builds. The build works as expected but with some new possibly dvs-related messages that I think are probably(?) not related to podman-hpc.

stephey@nid001036:/mscratch/sd/s/stephey/containerfiles/test> podman-hpc build -t elvis:test .
STEP 1/2: FROM docker.io/ubuntu:latest
Trying to pull docker.io/library/ubuntu:latest...
Getting image source signatures
Copying blob 837dd4791cdc skipped: already exists  
Copying config 1f6ddc1b25 done  
2023/06/12 17:50:16 bolt.Close(): funlock error: errno 524
2023/06/12 17:50:16 bolt.Close(): funlock error: errno 524
2023/06/12 17:50:16 bolt.Close(): funlock error: errno 524
Writing manifest to image destination
Storing signatures
STEP 2/2: WORKDIR /opt
--> Using cache a9f8d042863f1741730e38628a959d325e4877676dc59fcb14397ecc98da29cc
COMMIT elvis:test
2023/06/12 17:50:16 bolt.Close(): funlock error: errno 524
2023/06/12 17:50:16 bolt.Close(): funlock error: errno 524
2023/06/12 17:50:16 bolt.Close(): funlock error: errno 524
--> a9f8d042863
Successfully tagged localhost/elvis:test
a9f8d042863f1741730e38628a959d325e4877676dc59fcb14397ecc98da29cc
stephey@nid001036:/mscratch/sd/s/stephey/containerfiles/test>