Closed lastephey closed 1 year ago
Actually before I implement the part that pops it out for build
, @scanon or @danfulton could you please remind me why we didn't want additionalimagestore
on for build? Or am I remembering wrong?
I did some brief testing building with it on, and it seems ok.
I thought if you pull and migrate the image, then delete the original and retain the squashed version, and then try to do a build, it will try to use the image from the additionalimage store for your build, and this is problematic.
We might be able to avoid this if we don't copy the hashes over and generate a real hash or use some sort of dummy hash.
Will update to remove it for pull
and build
.
Fixed in #88
We need to include the additional image store as a default argument, otherwise users cannot see their squashed images
The only difficulty is that we don't want this on for build, so we'll need to pop this argument out