Build fails on undefined reference

[lachlansimpson]

On a clone of master, following the instructions here to build rpms on Centos 7 (7.4), with slurm 17.02.4 installed via rpm, I get:

[root@vmdv-res-head shifter]# rpmbuild -tb "shifter-16.08.3.tar.gz" --define "with_slurm /usr"
...
/root/rpmbuild/BUILD/shifter-16.08.3/wlm_integration/slurm/test/../../../src/UdiRootConfig.c:201: undefined reference to `free_gpu_support_config'
test_shifterSpank_config-UdiRootConfig.o: In function `fprint_UdiRootConfig':
/root/rpmbuild/BUILD/shifter-16.08.3/wlm_integration/slurm/test/../../../src/UdiRootConfig.c:322: undefined reference to `fprint_gpu_support_config'
test_shifterSpank_config-shifter_core.o: In function `mountImageVFS':
/root/rpmbuild/BUILD/shifter-16.08.3/wlm_integration/slurm/test/../../../src/shifter_core.c:1026: undefined reference to `execute_hook_to_activate_gpu_support'
collect2: error: ld returned 1 exit status
make[3]: *** [test_shifterSpank_config] Error 1
make[3]: Leaving directory `/root/rpmbuild/BUILD/shifter-16.08.3/wlm_integration/slurm/test'
make[2]: *** [check-am] Error 2
make[2]: Leaving directory `/root/rpmbuild/BUILD/shifter-16.08.3/wlm_integration/slurm/test'
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory `/root/rpmbuild/BUILD/shifter-16.08.3/wlm_integration/slurm'
make: *** [check-recursive] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.wdqf50 (%check)

RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.wdqf50 (%check)
[root@vmdv-res-head shifter]# 

What can I do to fix this? Looks like it's not finding SPANK?

[fcruzcscs]

I have not tested the rpm but the manual install should work: https://github.com/NERSC/shifter/blob/master/doc/install/manualinstallgpu.rst

[dmjacobsen]

Please only use the shifter-16.08 branch for release level code

[dmjacobsen]

This is fixed now in the master branch.