NERSC / shifter

Shifter - Linux Containers for HPC
Other
348 stars 65 forks source link

fix up some minor volume mount issues #215

Closed dmjacobsen closed 6 years ago

dmjacobsen commented 6 years ago

perform non-perNodeCache bind mount using from_real since that is the validated path (though from_buffer is equivalent, just messy); fix case like --volume=/cvmfs_nfs:/cvmfs, unmountTree aggressively unmounts any path for which the target (base, "/var/udiMount/cvmfs" in this case) is a substring, which causes the bind mount to be useless from the user perspective

dmjacobsen commented 6 years ago

this resolves the --volume=/cvmfs_nfs:/cvmfs problem that people have been observing.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.04%) to 64.562% when pulling 01eb31165809b98915ee9b6ae50f8b38c589744e on bugfix/substring_unmounts_during_volmount into 15fdf72bbf9fce5cf2930948e8ccefcecf8432ca on master.