BugFix: Incorrect error handling

NERSC / shifter

Shifter - Linux Containers for HPC

Other

348 stars 65 forks source link

BugFix: Incorrect error handling #254

Closed agaur-lbl closed 5 years ago

agaur-lbl commented 5 years ago

If we fail to load job data, we should propagate that error code and exit cleanly. In the bug we saw- despite getting incorrect job data, we were not handling the error correctly and allowing shifter to continue setupRoot operation on shared nodes.

This patch, exits the prolog.

Signed-off-by: Aditi Gaur agaur@lbl.gov

agaur-lbl commented 5 years ago

This new PR keeps dlopen change

coveralls commented 5 years ago

Coverage remained the same at 64.65% when pulling 94d2d8400f97462b16984f0b906138d987ff815e on agaur-lbl:prolog_fix2 into eaf113ce2526843b54865029c7de5acf78bac46c on NERSC:master.

dmjacobsen commented 5 years ago

This looks good to me.