search

NERSC / shifter

Shifter - Linux Containers for HPC
Other
348 stars 65 forks source link

Feature/allow var tmp #264

Closed dmjacobsen closed 4 years ago

dmjacobsen commented 4 years ago

for issue #262

agaur-lbl commented 4 years ago

Overall looks good, i would like paths to be configurable. Special paths can be given special consideration.

dmjacobsen commented 4 years ago

the spacing is corrected. It looks like travisci fell apart on the previous push owing to a transient failure at travis. hopefully this push will build.

dmjacobsen commented 4 years ago

re: making paths configurable, i believe that is in-general possible. /var is a little touchy owing to its security issues. I don't think there is any harm in /var/tmp, but other paths within var could be more problematic. We can re-address the overall configurability in a branch focused on that.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.05%) to 64.695% when pulling ff923b6f6d737cbf91dfeffe1a7c58e98c35298a on feature/allow_var_tmp into 5186aac75ba1b83aed8586aba3eace4fef146aaa on master.