search

NERSC / shifter

Shifter - Linux Containers for HPC
Other
348 stars 65 forks source link

Fix for #267 #269

Closed scanon closed 4 years ago

scanon commented 4 years ago

This fixes #267. It does a monkeypatch to the tarfile library.

The monkey patch as can be seen is from Vincent Batts.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.05%) to 64.736% when pulling ee1c2d9717b4441a0f3aab3f28dad198a96262a2 on scanon:issue267 into c13ffe64e5cf14f8c3ba9445c26d4cd7e4d7fea7 on NERSC:master.

dmjacobsen commented 4 years ago

i'm trying to understand this; do we really want to extract files with xattrs? is there a way to simply squash whatever xattrs there might be?

scanon commented 4 years ago

I don't think this changes the behavior of the extraction. The issue is the tarfile barfs on the unicode encoded headers which means we can pull some newer images.

dmjacobsen commented 4 years ago

right, i think i understood that from the code; i'm more wondering if the code should be deleting the xattrs instead of fixing them

dmjacobsen commented 4 years ago

perhaps ALL the xattrs; it's unclear what value they generate in the shifter model of execution