munge.py: get error message from libmunge

NERSC / shifter

Shifter - Linux Containers for HPC

Other

348 stars 65 forks source link

munge.py: get error message from libmunge #277

Open maxim-belkin opened 4 years ago

maxim-belkin commented 4 years ago

Obtain error messages from libmunge instead of hard-coding them.

maxim-belkin commented 4 years ago

Perhaps, we could prefix error messages with "Munge error:"...

maxim-belkin commented 4 years ago

@dmjacobsen, @scanon, please let me know if you have any comments or concerns regarding this PR

scanon commented 4 years ago

It looks reasonable. I need to try it out. I think it will break our test since I mock munge in those.

coveralls commented 4 years ago

Coverage increased (+0.009%) to 78.4% when pulling eb8713beb019b8f0faa0bc424358932ed401447f on maxim-belkin:munge-str-error into 4c97268698a7c14c3bc3b57d7da52c247a4f5923 on NERSC:master.

maxim-belkin commented 3 years ago

We've been using Shifter with this patch on Blue Waters for a while now and didn't see any problems/issues related to this change.