Remove autoclear option from squashfs mount

NERSC / shifter

Shifter - Linux Containers for HPC

Other

348 stars 65 forks source link

Remove autoclear option from squashfs mount #286

Open uvNikita opened 3 years ago

uvNikita commented 3 years ago

Unless I'm missing something, it seems like it's not supported in the new kernels.

Without this patch I'm getting "Unknown parameter autoclear" in dmesg when attempting to mount squashfs image. I think old kernels might have just ignored unsupported options.

coveralls commented 3 years ago

Coverage remained the same at 78.399% when pulling cb7c3211581383981453952ed8cfea17effd2c5f on uvNikita:squashfs/autoclear into 771dcc40c7c01e6ebe8f5540502e67b703863164 on NERSC:master.

scanon commented 3 years ago

@dmjacobsen Can you look at this?

scanon commented 3 years ago

I've run into this as well. I'm still discussing with @dmjacobsen the ramifications of disabling it. But the newer kernels simply do not recognize this option.

scanon commented 2 years ago

We have confirmed that removing the autoclear is safe. @dmjacobsen was concerned about. We will work on a different fix that will somehow (TBD) determine if the flag should be used or not. Leaving off the autoclear on older kernels will result in orphaned loopback mounts.