search

NERSC / shifter

Shifter - Linux Containers for HPC
Other
348 stars 65 forks source link

Switch to GitHub Actions #310

Closed scanon closed 2 years ago

scanon commented 2 years ago

This required ignoring issues with valgrind. So we need to examine those results to see if they are real issues or something related to the switch to GHA.

agaur-lbl commented 2 years ago

Looks good to me, my only suggestion is, it would be nice to have valgrind in a separate step instead being lumped with Cunit. Valgrind output is just more noisy and it may be better to keep it in a separate.

scanon commented 2 years ago

I tweaked things to address @agaur-lbl 's feedback. Merging...