search

NERSC / shifter

Shifter - Linux Containers for HPC
Other
348 stars 65 forks source link

confirmation when using shifterimg login #321

Open shahzebsiddiqui opened 2 years ago

shahzebsiddiqui commented 2 years ago

@scanon

It would be good if you can show a confirmation when using shifterimg login to login to registry to note that login was successful

 ~/ shifterimg login
default username: siddiq90
default password:

If i do some bogus username it still finishes as if login was successful. I think just a message would help. If there is failure in login i think that should be reported.

 ~/ shifterimg login
default username: xyz
default password:
shahzebsiddiqui commented 2 years ago

This what docker reports when you login to a registry

[siddiq90@podman01]~% docker login registry.services.nersc.gov
Authenticating with existing credentials for registry.services.nersc.gov
Existing credentials are valid. Already logged in to registry.services.nersc.gov
scanon commented 2 years ago

The reason we haven't added this is the authentication process is a bit involved and that part is written in C. So it would be a good bit of work to add. We could add something to the output that makes it clear that the login isn't actually checked.

shahzebsiddiqui commented 2 years ago

I see yeah it bit unclear when one does shifterimg login that we are registered, yeah some extra output would be useful since i type my credentials and i presume it works but no message doesn't help since i can type incorrect password and nothing will happen.