NERSC / timemory

Modular C++ Toolkit for Performance Analysis and Logging. Profiling API and Tools for C, C++, CUDA, Fortran, and Python. The C++ template API is essentially a framework to creating tools: it is designed to provide a unifying interface for recording various performance measurements alongside data logging and interfaces to other tools.
https://timemory.readthedocs.io/en/develop/
Other
352 stars 38 forks source link

Fix hip backend when hip is not enabled #240

Closed tkonolige closed 2 years ago

tkonolige commented 2 years ago

hipMemset and hipMemsetAsync fall back to std::memset when hip is not enabled. These fallbacks incorrectly returned the return value of std::memset (which returns the memset destination).

jrmadsen commented 2 years ago

Merging these despite all the CI not finishing since there are not CI checks for this (at least not yet) and thus, would unnecessarily burn free credits for the CI.