NESCent / popgenInfo

Vignettes for Population Genetics in R
http://popgen.nescent.org
MIT License
20 stars 50 forks source link

adjust for update to apex #176

Closed zkamvar closed 8 years ago

zkamvar commented 8 years ago

The apex package is going to update soon (See: https://github.com/thibautjombart/apex/issues/46). With this update comes a change to the accessor locusNames(). It has now been changed to getLocusNames() and setLocusNames(). This will have to change in these two lines: https://github.com/NESCent/popgenInfo/blame/cb0d66460c062ff8e2990c185b7f737f69f54050/use/PopDiffSequenceData.Rmd#L50-L51

The pull request should only be initiated once apex is on CRAN and the Docker container is rebuilt

zkamvar commented 8 years ago

Apex has been updated. As soon as the docker container is updated, we should create a pull request from the apex-update branch.

hlapp commented 8 years ago

I triggered a rebuild, succeeded. Submitted pull request, see #181. Triggered re-run of the CI test.

hlapp commented 8 years ago

I believe this is done.