search

NESCent / popgenInfo

Vignettes for Population Genetics in R
http://popgen.nescent.org
MIT License
22 stars 50 forks source link

update TEMPLATE #189

Closed zkamvar closed 8 years ago

zkamvar commented 8 years ago

This fixes #186 and fixes #187.

I've additionally added a couple of more chunks to show that echo and eval are true by default.

hlapp commented 8 years ago

Looks great to me. Can @smanel or @mmlopezu take a look too and signal agreement that this completes addressing the reviewer comments in #186 and #187?

mmlopezu commented 8 years ago

@zkamvar

I think these modifications address comments from the reviewer. I personally think these great additions! Should we suggest these changes for all existing vignettes? Or only new ones?

hlapp commented 8 years ago

I don't want to cut off the discussion - it can continue here regardless - but I'm going to merge this given @mmlopezu approval.

zkamvar commented 8 years ago

I think it might be prudent to suggest changes to the existing vignettes.