I would be happy to support merging these changes, but I would like to request one change.
The current pull request contains all of the commits that were made last year which means that you are working from an old fork. The easiest way to update without using the command line is to create a new fork [^1]. Please create a new fork from the current repository and add your changes in a new branch there (following GitHub flow).
Of course, this means that you should first delete your current fork. Before you do that, make sure you have a copy of your changes saved on your computer. After you've deleted your fork, you should do the following:
re-fork the popgenInfo repository
create a new branch in your fork
add your changes to the use/2016-12-13_MEM_outlier.Rmd file in that branch
make a new pull request
Additionally, the build is failing, but that's coming from the chunk that reads in the data, so I'm uncertain as to why that's happening when it worked before and continues to work on my machine with the same environment. 🤷♂️
Error message
```
Quitting from lines 46-51 (2016-12-13_MEM_outlier.Rmd)
Error in file(file, "rt") : cannot open the connection
Calls: ... withVisible -> eval -> eval -> read.csv -> read.table -> file
In addition: Warning messages:
1: In grep("\n", x) : input string 239 is invalid in this locale
2: In grep("\n", x) : input string 250 is invalid in this locale
3: In grep("^(---|\\.\\.\\.)\\s*$", lines) :
input string 239 is invalid in this locale
4: In grep("^(---|\\.\\.\\.)\\s*$", lines) :
input string 250 is invalid in this locale
5: In grepl(chunk.begin, lines) :
input string 239 is invalid in this locale
6: In grepl(chunk.begin, lines) :
input string 250 is invalid in this locale
7: In grepl(chunk.end, lines) : input string 239 is invalid in this locale
8: In grepl(chunk.end, lines) : input string 250 is invalid in this locale
```
Thanks,
Zhian
[^1]: For the record, I also wish there were an easier way 😐
Hello again, @BrennaF!
Thank you for your updates to the vignette! 🙌 If I'm correct, the changes you've made to the existing vignette on the site are here: https://github.com/NESCent/popgenInfo/pull/201/commits/08edf5a545736195bd1a36ac11b738d52235098a, and I think they add good clarification for the method. 😃
I would be happy to support merging these changes, but I would like to request one change. The current pull request contains all of the commits that were made last year which means that you are working from an old fork. The easiest way to update without using the command line is to create a new fork [^1]. Please create a new fork from the current repository and add your changes in a new branch there (following GitHub flow).
Of course, this means that you should first delete your current fork. Before you do that, make sure you have a copy of your changes saved on your computer. After you've deleted your fork, you should do the following:
use/2016-12-13_MEM_outlier.Rmdfile in that branchAdditionally, the build is failing, but that's coming from the chunk that reads in the data, so I'm uncertain as to why that's happening when it worked before and continues to work on my machine with the same environment. 🤷♂️
Error message
``` Quitting from lines 46-51 (2016-12-13_MEM_outlier.Rmd) Error in file(file, "rt") : cannot open the connection Calls:Thanks, Zhian
[^1]: For the record, I also wish there were an easier way 😐