Closed BrennaF closed 6 years ago
Looks good to me! Now we need approval from one more maintainer. @smanel, @hlapp?
Sent from my iPhone
On Oct 21, 2017, at 11:22, Brenna Forester notifications@github.com wrote:
Hi @zkamvar!
I think I updated correctly. I modified the link ("new hyperlink - download data") so that right clicking downloads the csv file (the first change was not correct).
Thanks for your help! 😃
You can view, comment on, or merge this pull request online at:
https://github.com/NESCent/popgenInfo/pull/202
Commit Summary
add hyperlink to data file new hyperlink - download data File Changes
M use/2016-12-13_MEM_outlier.Rmd (2) Patch Links:
https://github.com/NESCent/popgenInfo/pull/202.patch https://github.com/NESCent/popgenInfo/pull/202.diff — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
Looks good to me too. Squash and merge, I assume? Or keep each commit?
I vote for squash
Sent from my iPhone
On Oct 21, 2017, at 16:26, Hilmar Lapp notifications@github.com wrote:
Looks good to me too. Squash and merge, I assume? Or keep each commit?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
Thanks @zkamvar and @hlapp !
Hi @zkamvar!
I think I updated correctly. I modified the link ("new hyperlink - download data") so that right clicking downloads the csv file (the first change was not correct).
Thanks for your help! 😃