search

NESCent / popgenInfo

Vignettes for Population Genetics in R
http://popgen.nescent.org
MIT License
22 stars 50 forks source link

Migrates to CircleCI version 2 #212

Closed hlapp closed 6 years ago

hlapp commented 6 years ago

In practice this isn't a migration so much as a rewrite, as the CircleCI configuration changed quite drastically from version 1 to version 2.

As a result, rewriting the config file alone is in fact far from sufficient, and making this work precipitates a number of changes in how the process is run. More specifically, originally the CircleCI configuration replicated the notion that we are on a machine that can build and run Docker containers. This mirrored the building locally situation. In version 2, this is still possible (by using "machine: true"), but more natural and the long term path is that we are in "the" (or a) container.

We could still by choice of primary container and using multiple containers stay in the paradigm of building our container on the fly and then running it repeatedly. But that seemed to get more complex than needed, and it works more naturally in version 2 to simply do everything in the target container.

In terms of the target container, we were using the one built on the fly as essentially a content-less wrapper around the hlapp/rpopgen container from Docker Hub, so this is what we are changing to.

Closes #204.

hlapp commented 6 years ago

Not sure why this isn't triggering a build.

hlapp commented 6 years ago

Will try to merge to master, otherwise may have to reinstate on CircleCI from scratch.

zkamvar commented 6 years ago

Thank you for tackling this, Hilmar. This reflects my own struggles with the migration.