search

NESTCollaboration / nestpy

Raw Python bindings to the NEST library using pybind11.
GNU General Public License v3.0
13 stars 19 forks source link

Sync with NEST v2.3.0beta #72

Closed sophiafarrell closed 2 years ago

sophiafarrell commented 2 years ago

Preparation to make v1.5.0 nestpy, these tests are performed on most recent NEST version (beta) to catch already existing fixes needed.

sophiafarrell commented 2 years ago

Probably we should not tag to NEST 2.3.0beta if we’re going to immediately tag a day after or so. So I’m not going to tag this and just re-edit the HISTORY to reflect that we’re including both changes, in the imminent version, nestpy v1.5.0. I realize this is a bit obscure, but hopefully we will lose less people along the way.

sophiafarrell commented 2 years ago

Tagging @grischbieter to review, all checks passed, but just so I have an extra set of eyes. Mainly, see my comment above about versioning.. I'm not going to actually tag this as 1.4.12 unless you object, since I believe the new NEST is right on our heels and I don't want 2 tags within 1-2 days. Let me know if this isn't the best way to do it.

sophiafarrell commented 2 years ago

Note for future selves and anyone following this:

We have synced not only to 2.3.0beta (first few commits), but also to the most current commit of NEST. This will allow us a speedy transition to v2.3.0 NEST, which is up next. The version and history is in place, but this merge is more of a "pseudo" version in that we will not tag, as we want to tag and have everyone on board with v1.5 in the next day(s).

@grischbieter checks have passed!