search

NESTCollaboration / nestpy

Raw Python bindings to the NEST library using pybind11.
GNU General Public License v3.0
13 stars 19 forks source link

fix version number for setup.py #75

Closed sophiafarrell closed 2 years ago

sophiafarrell commented 2 years ago

Really minor PR, but because there's a tag I want review on how best to do this, as tags are tricky.

The point of this is to ensure that PyPi and thus pip recognize this as v1.5.0, as setup.py has the wrong version in place. I haven't found how safe it is to re-tag, but I'd hate to re-tag for something this small. Is there a way we can merge this, delete the tag, and re-tag immediately? I didn't want to overstep @grischbieter, since your documentation on v1.5.0 was great. So maybe if this looks good, we can merge, then if you agree this is minor enough to warrant a re-tag, we can delete/retag to this latest commit.

grischbieter commented 2 years ago

Hey Sophia, sorry for my oversight on this. I think we should get this merged, and I don't see an issue with removing the v1.5.0 tag and re-tagging this commit. As long as every user can see v1.5.0 and have things work properly for them, I can't imagine anything wrong with that approach.