search

NESTCollaboration / nestpy

Raw Python bindings to the NEST library using pybind11.
GNU General Public License v3.0
13 stars 19 forks source link

fix bug in bindings for Kr83m #85

Closed sophiafarrell closed 2 years ago

sophiafarrell commented 2 years ago

Proposed change to fix this issue: https://github.com/NESTCollaboration/nestpy/issues/84

sophiafarrell commented 2 years ago

@grischbieter, can you double-check my work and let me know if this PR causes any unforeseen problems? I'm just changing this line which was not bound correctly to the function, see #84 for more info. https://github.com/NESTCollaboration/nestpy/blob/69b61e65706ef2ddc1695ad507d180fc2150f7ae/src/nestpy/bindings.cpp#L268

I remember we had some issue a few months ago regarding these arguments but I think not changing the bindings was just an oversight... let me know your thoughts if you can -- especially since as we know the Travis builds like to fail on us.

grischbieter commented 2 years ago

This looks okay to me. I had a custom nestpy project where I did the same thing and didn't have any issues. I can't figure out why the CI is failing, but I think its unrelated and "normal" based on recent experiences. I'm okay with this being merged.