search

NESTCollaboration / nestpy

Raw Python bindings to the NEST library using pybind11.
GNU General Public License v3.0
13 stars 19 forks source link

No more travis, pipy uploads via github actions #86

Closed JoranAngevaare closed 2 years ago

JoranAngevaare commented 2 years ago

Reorganize CI, remove travis and only use

Fix the pipy uploads of nestpy that have been problematic from travis for a while. You can see from this PR that it works on python 3.8 - 3.10 for linux (where we did have most issues).

Drop explicit python 2.7, 3.4 and 3.6 support

As discussed with @sophiafarrell , this would drop support of some ancient python versions. If super urgent, I could try a bit harder to get it in, but maybe it's fairer to have people just build it from source.

Why so many commits?

I made a new pipy releases using my own fork to make releases without having to debug on nestpy's master. I had to go back and forth trying to debug several aspects, e.g. having the different operating systems supported

sophiafarrell commented 2 years ago

pip install works, however if I try to then run import nestpy, the module is basically blank. 

import nestpy
print(nestpy.__file__) # returns nothing

I've found that the breakage happened somewhere in between 1.5.4 and 1.5.18 of nestpy-test2 (specify either of those versions, then try to see what your install of nestpy contains, and you'll see what I mean). So it is happening somewhere in this set of differences: https://github.com/JoranAngevaare/nestpy/compare/v1.5.4...v1.5.18

I've found the issue is the packages argument of setup so we will have to address how to include lib for recompiling later. For now everything else is fine.

JoranAngevaare commented 2 years ago

Ah great, thanks @sophiafarrell for spotting that!