search

NET-A-PORTER / scala-uri

Simple scala library for building and parsing URIs
Other
261 stars 33 forks source link

Fixes MatrixParam parsing for issue #102 #103

Closed fsaintjacques closed 8 years ago

codecov-io commented 9 years ago

Current coverage is 92.50%

Merging #103 into master will not affect coverage as of 6145b04

@@            master   #103   diff @@
=====================================
  Files           19     19       
  Stmts          200    200       
  Branches        12     12       
  Methods          0      0       
=====================================
  Hit            185    185       
  Partial          0      0       
  Missed          15     15

Review entire Coverage Diff as of 6145b04

Powered by Codecov. Updated on successful CI builds.

fsaintjacques commented 9 years ago

@theon would it be possible to release a fix for this in the maven repo (for both scala 2.10/2.11) ?

theon commented 8 years ago

Sorry for the delay! This one slipped through the net. I will get a release out today.

theon commented 8 years ago

and thanks for the contribution :)

theon commented 8 years ago

I just published a 0.4.9 release which should have this included.

fsaintjacques commented 8 years ago

Note that my solution is not 100% clean, there might be a better way to shape the parsing. This could probably be fixed by changing the reference from zeroOrMore(_matrixParam) to something that would resemble to zeroOrMore(optional(_matrixParam)).