search

NET-A-PORTER / scala-uri

Simple scala library for building and parsing URIs
Other
261 stars 33 forks source link

Support scala 2.11.8 #120

Closed putgeminmouth closed 5 years ago

codecov-io commented 7 years ago

Current coverage is 92.24% (diff: 100%)

Merging #120 into master will not change coverage

@@             master       #120   diff @@
==========================================
  Files            21         21          
  Lines           245        245          
  Methods         236        236          
  Messages          0          0          
  Branches          9          9          
==========================================
  Hits            226        226          
  Misses           19         19          
  Partials          0          0

Powered by Codecov. Last update c8ecdf4...33d4d53

theon commented 7 years ago

Hi @putgeminmouth,

Thanks for the PR. scala 2.11.8 should already be supported. crossScalaVersions is used to create separate builds for scala 2.10 and 2.11, because they are binary incompatible, but minor versions of scala are binary compatible with each other. The 2.11 build of scala-uri (compiled with 2.11.7) should run fine in your project using 2.11.8.

Let me know if you have any issues runnning scala-uri against 2.11.8.