search

NET-A-PORTER / scala-uri

Simple scala library for building and parsing URIs
Other
261 stars 33 forks source link

Support Iterable[(String, String)] in ? operator #79

Open acjay opened 9 years ago

acjay commented 9 years ago

Why not also allow ? and & accept an Iterable of pairs? That would be more in fitting with the dsl than addParams.

theon commented 9 years ago

Makes sense. I can add a overloaded version of ? and &.

theon commented 8 years ago

I need to revisit this. I think I need to audit all the parameter and return types and make sure they are sensible.

There was a recent twitter conversation about this where the consensus for return types was that they should be as specific as possible. There were mixed views on parameters types.