search

NET-A-PORTER / scala-uri

Simple scala library for building and parsing URIs
Other
261 stars 33 forks source link

Add double-quote as a character to be percent escaped #86

Closed lloydmeta closed 9 years ago

lloydmeta commented 9 years ago

RFC 2396 defines a set of excluded characters that should be escaped; most of these are covered already by RFC 3986, but not the double quote character.

The reason for its inclusion is

double-quote (") characters are excluded because they are often used as the delimiters around URI in text documents and protocol fields.

For example:

<a href="http://beachape.com/"hello""> would be problematic.

lloydmeta commented 9 years ago

I'm unsure if this should be included in the list of things to be encoded by default.

philwill-nap commented 9 years ago

@lloydmeta I'm sure that it should.