search

NETMF / netmf-interpreter

.NET Micro Framework Interpreter
http://netmf.github.io/netmf-interpreter/
Other
487 stars 224 forks source link

Undefined Environment Variables FLAVOR_WIN (FLAVOR, Configuration,..)? #279

Open doingnz opened 9 years ago

doingnz commented 9 years ago

_FLAVORWIN appears to be undefined? or did I miss something? Do we need add back in the lines to set the default FLAVOR_WIN to init.cmd?

tools\scripts\init.cmd script in the past defined two environment variables FLAVOR_DAT and FLAVOR_WIN as follows:

if /I "%FLAVOR_DAT%"   == "Debug"   set FLAVOR_DAT=Debug
if /I "%FLAVOR_DAT%"   == "Release" set FLAVOR_DAT=Release
if    "%FLAVOR_DAT%"   == ""        set FLAVOR_DAT=Release

if /I "%FLAVOR_WIN%"   == "Debug"   set FLAVOR_WIN=Debug
if /I "%FLAVOR_WIN%"   == "Release" set FLAVOR_WIN=Release
if    "%FLAVOR_WIN%"   == ""        set FLAVOR_WIN=Release

In init.cmd in MF v4.4, the above lines defining a default for FLAVOR_WIN have been removed leaving FLAVOUR_DAT alone.

FLAVOR_WIN is used later in the same init.cmd and it has not been defined.

set BUILD_TREE_SERVER=%BUILD_ROOT%\%FLAVOR_WIN%\server

also in setenv_base.cmd

set PATH=%CLRROOT%\BuildOutput\Public\%FLAVOR_WIN%\Test\Server\dll;%PATH%

It is referenced in many other project files..

  C:\Projects\BPplus\netmf\netmf-interpreter\BuildEnv.props(23):    <FLAVOR_WIN Condition="'$(FLAVOR_WIN)'=='' AND '$(Configuration)'=='Debug'" >Debug</FLAVOR_WIN>
  C:\Projects\BPplus\netmf\netmf-interpreter\BuildEnv.props(24):    <FLAVOR_WIN Condition="'$(FLAVOR_WIN)'=='' AND '$(Configuration)'!='Debug'" >Release</FLAVOR_WIN>
  C:\Projects\BPplus\netmf\netmf-interpreter\setenv_base.cmd(74):set PATH=%CLRROOT%\BuildOutput\Public\%FLAVOR_WIN%\Test\Server\dll;%PATH%
  C:\Projects\BPplus\netmf\netmf-interpreter\setenv_base.cmd(92):Title MF %FLAVOR_WIN% (%COMPILER_TOOL% %COMPILER_TOOL_VERSION_NUM%)
  C:\Projects\BPplus\netmf\netmf-interpreter\CLR\Tools\EmulatorInterface\EmulatorInterface.csproj(6):        <Configuration Condition="'$(FLAVOR_WIN)'!=''">$(FLAVOR_WIN)</Configuration>
  C:\Projects\BPplus\netmf\netmf-interpreter\Framework\Debugger\WinUsb\WinUsb.csproj(6):    <Configuration Condition="'$(FLAVOR_WIN)'!=''">$(FLAVOR_WIN)</Configuration>
  C:\Projects\BPplus\netmf\netmf-interpreter\Framework\Tools\AbortHandlerClient\AbortHandlerClient.csproj(5):        <Configuration Condition="'$(FLAVOR_WIN)'!=''">$(FLAVOR_WIN)</Configuration>
  C:\Projects\BPplus\netmf\netmf-interpreter\Framework\Tools\BuildTasks\BuildTasks.csproj(6):        <Configuration Condition="'$(FLAVOR_WIN)'!=''">$(FLAVOR_WIN)</Configuration>
  C:\Projects\BPplus\netmf\netmf-interpreter\Framework\Tools\BuildTasksInternal\InternalBuildTasks.csproj(6):        <Configuration Condition="'$(FLAVOR_WIN)'!=''">$(FLAVOR_WIN)</Configuration>
  C:\Projects\BPplus\netmf\netmf-interpreter\Framework\Tools\BuildTasksNativeBuild\NativeBuildTasks.csproj(5):        <Configuration Condition="'$(FLAVOR_WIN)'!=''">$(FLAVOR_WIN)</Configuration>
  C:\Projects\BPplus\netmf\netmf-interpreter\Framework\Tools\DumpTypeHashes\DumpTypeHashes.csproj(5):        <Configuration Condition="'$(FLAVOR_WIN)'!=''">$(FLAVOR_WIN)</Configuration>
  C:\Projects\BPplus\netmf\netmf-interpreter\Framework\Tools\Emulator\Emulator.csproj(6):        <Configuration Condition="'$(FLAVOR_WIN)'!=''">$(FLAVOR_WIN)</Configuration>
  C:\Projects\BPplus\netmf\netmf-interpreter\Framework\Tools\Emulators\CommandLineEmulator\CommandLineEmulator.csproj(5):        <Configuration Condition="'$(FLAVOR_WIN)'!=''">$(FLAVOR_WIN)</Configuration>
  C:\Projects\BPplus\netmf\netmf-interpreter\Framework\Tools\MFDeploy\Application\MFDeploy.csproj(6):    <Configuration Condition="'$(FLAVOR_WIN)'!=''">$(FLAVOR_WIN)</Configuration>
  C:\Projects\BPplus\netmf\netmf-interpreter\Framework\Tools\MFDeploy\Library\MFDeployEngine.csproj(6):    <Configuration Condition="'$(FLAVOR_WIN)'!=''">$(FLAVOR_WIN)</Configuration>
  C:\Projects\BPplus\netmf\netmf-interpreter\Framework\Tools\MFDeploy\MFDeployCom\MFDeployCom.csproj(6):    <Configuration Condition="'$(FLAVOR_WIN)'!=''">$(FLAVOR_WIN)</Configuration>
  C:\Projects\BPplus\netmf\netmf-interpreter\Framework\Tools\MFProfiler\MFProfiler.csproj(6):        <Configuration Condition="'$(FLAVOR_WIN)'!=''">$(FLAVOR_WIN)</Configuration>
  C:\Projects\BPplus\netmf\netmf-interpreter\Framework\Tools\ScatterFileProcessor\ScatterFileProcessor.csproj(5):        <Configuration Condition="'$(FLAVOR_WIN)'!=''">$(FLAVOR_WIN)</Configuration>
  C:\Projects\BPplus\netmf\netmf-interpreter\Framework\Tools\SerialDump\SerialDump.csproj(5):        <Configuration Condition="'$(FLAVOR_WIN)'!=''">$(FLAVOR_WIN)</Configuration>
  C:\Projects\BPplus\netmf\netmf-interpreter\Product\AllSDK\ItemTemplates\CSharp\AssemblyInfo\AssemblyInfoTemplateProject.csproj(25):    <Configuration Condition="'$(FLAVOR_WIN)'!=''">$(FLAVOR_WIN)</Configuration>
  C:\Projects\BPplus\netmf\netmf-interpreter\Product\AllSDK\ItemTemplates\CSharp\Class\ClassTemplateProject.csproj(25):    <Configuration Condition="'$(FLAVOR_WIN)'!=''">$(FLAVOR_WIN)</Configuration>
  C:\Projects\BPplus\netmf\netmf-interpreter\Product\AllSDK\ItemTemplates\VisualBasic\Class\VBClassTemplateProject.csproj(25):    <Configuration Condition="'$(FLAVOR_WIN)'!=''">$(FLAVOR_WIN)</Configuration>
  C:\Projects\BPplus\netmf\netmf-interpreter\Product\AllSDK\ProjectTemplates\CSharp\EmulatorTemplate\EmulatorTemplateProject.csproj(21):    <Configuration Condition="'$(FLAVOR_WIN)'!=''">$(FLAVOR_WIN)</Configuration>
  C:\Projects\BPplus\netmf\netmf-interpreter\Product\AllSDK\ProjectTemplates\CSharp\ExeTemplate\ExeTemplateProject.csproj(25):    <Configuration Condition="'$(FLAVOR_WIN)'!=''">$(FLAVOR_WIN)</Configuration>
  C:\Projects\BPplus\netmf\netmf-interpreter\Product\AllSDK\ProjectTemplates\CSharp\LibTemplate\LibTemplateProject.csproj(25):    <Configuration Condition="'$(FLAVOR_WIN)'!=''">$(FLAVOR_WIN)</Configuration>
  C:\Projects\BPplus\netmf\netmf-interpreter\Product\AllSDK\ProjectTemplates\CSharp\WinTemplate\WinTemplateProject.csproj(25):    <Configuration Condition="'$(FLAVOR_WIN)'!=''">$(FLAVOR_WIN)</Configuration>
  C:\Projects\BPplus\netmf\netmf-interpreter\Product\AllSDK\ProjectTemplates\VB\EmulatorTemplate\VBEmulatorTemplateProject.csproj(21):    <Configuration Condition="'$(FLAVOR_WIN)'!=''">$(FLAVOR_WIN)</Configuration>
  C:\Projects\BPplus\netmf\netmf-interpreter\Product\AllSDK\ProjectTemplates\VB\ExeTemplate\VBExeTemplateProject.csproj(25):    <Configuration Condition="'$(FLAVOR_WIN)'!=''">$(FLAVOR_WIN)</Configuration>
  C:\Projects\BPplus\netmf\netmf-interpreter\Product\AllSDK\ProjectTemplates\VB\LibTemplate\VBLibTemplateProject.csproj(25):    <Configuration Condition="'$(FLAVOR_WIN)'!=''">$(FLAVOR_WIN)</Configuration>
  C:\Projects\BPplus\netmf\netmf-interpreter\Product\AllSDK\ProjectTemplates\VB\WinTemplate\VBWinTemplateProject.csproj(25):    <Configuration Condition="'$(FLAVOR_WIN)'!=''">$(FLAVOR_WIN)</Configuration>
  C:\Projects\BPplus\netmf\netmf-interpreter\Test\Platform\Tools\AutomationTasks\bap.cmd(4):if /i not "%FLAVOR_WIN%"=="Debug" (
  C:\Projects\BPplus\netmf\netmf-interpreter\tools\scripts\init.cmd(19):if /I "%FLAVOR_WIN%"   == "Debug"   set FLAVOR_WIN=Debug
  C:\Projects\BPplus\netmf\netmf-interpreter\tools\scripts\init.cmd(20):if /I "%FLAVOR_WIN%"   == "Release" set FLAVOR_WIN=Release
  C:\Projects\BPplus\netmf\netmf-interpreter\tools\scripts\init.cmd(21):if    "%FLAVOR_WIN%"   == ""        set FLAVOR_WIN=Release
  C:\Projects\BPplus\netmf\netmf-interpreter\tools\scripts\init.cmd(44):set BUILD_TREE_SERVER=%BUILD_ROOT%\%FLAVOR_WIN%\server
  C:\Projects\BPplus\netmf\netmf-interpreter\tools\Targets\Microsoft.SPOT.Support.Settings(105):    <FLAVOR_WIN Condition="'$(FLAVOR_TMP)'=='Debug'" >Debug</FLAVOR_WIN>
  C:\Projects\BPplus\netmf\netmf-interpreter\tools\Targets\Microsoft.SPOT.Support.Settings(106):    <FLAVOR_WIN Condition="'$(FLAVOR_TMP)'!='Debug'" >Release</FLAVOR_WIN>

"Microsoft.SPOT.Support.Settings" are not included as per the commented out Import in "Microsoft.SPOT.Build.Setup.Targets"

doingnz commented 9 years ago

Please can we clarify the intended use for the following

MSBuild will use local values defined in Microsoft.SPOT.Build.Setup.Targets, which can result in different values for BUILD_TREE etc. to those defined in the environment variables. Can be confusing when switching between Debug and Release builds.

To build a debug version of MF and solution, would appear one needs to:

set FLAVOR=Debug
set Configuration=Debug
set FLAVOR_WIN=Debug
set FLAVOR_DAT=Debug
setenv_ds5 5.05
build_sdk
cd  Solutions\<platformname> 
msbuild /flp:verbosity=detailed /clp:verbosity=minimal
cd ..\.. 
msbuild /flp:verbosity=detailed /clp:verbosity=minimal build.dirproj
%BUILD_TEST_TREE_SERVER%\dll\RunTests.exe

Not that build_sdk.cmd has /p:FLAVOR=RTM, so to strictly do all debug build, need a buildDebug_sdk.cmd with RTM replaced with Debug or deleted to let it pick up the environment variable.

Maybe for V4.4 add FLAVOR_WIN to init.cmd

Possibly consider replication of logic that uses FLAVOR and Configuration to set FLAVOR_WIN and FLAVOUR_DAT into init.cmd?

Maybe I am just confused and need a wiki page to explain things?

Kind regards, Richard

smaillet-ms commented 9 years ago

You wouldn't be the only one confused! The whole nonsense of Flavors, configurations, etc...has been a HUGE source of problems and attempts to clean up and simplify it end up causing troubles. (The only way out I know of is a complete re-write of the build infrastructure to used proper VCXPROJ for native code and CSPROJ, etc.. for managed). I'll do my best to explain the insanity: FLAVOR -> Build "flavor) Release, Debug, etc... for Device target code Configuration -> standard Visual Studio Project configuration, for projects that are proper VS projects (e.g. CSPROJ and VBPROJ) FLAVOR_WIN => Build flavor for the Windows based tools, libs, dlls and assemblies. That is if it runs on the desktop, this is what determines the build type (debug, release, etc...). This is also used when building target binaries to determine the location of the tools to perform the actual build. FLAVOR_DAT determines the build flavor for the "built-in" assemblies this is used to determine the path used to create the flash image binary of the PE files. Generally this is the same as FLAVOR.

In the build system FLAVOR_WIN defaults to FLAVOR if it isn't already set.