NETWAYS / ansible-collection-elasticstack

A collection to install and manage the Elastic Stack
GNU General Public License v3.0
9 stars 8 forks source link

Remove redundante waiting tasks #139

Closed widhalmt closed 1 year ago

widhalmt commented 1 year ago

In tasks/elasticsearch-security.yml we have several versions of tasks waiting for Elasticsearch to start.

I guess the following is redundant and can be removed.

- name: Check for open port tcp {{ elastic_elasticsearch_http_port }}
  wait_for:
    port: "{{ elastic_elasticsearch_http_port }}"
  tags:
    - certificates
    - renew_ca
    - renew_es_cert

I guess, when we remove it, we need to add the tags to the other waiting tasks. @afeefghannam89 you put a lot of effort in those tags, could you plese make sure we don't break anything and remove this task (if I'm right)

afeefghannam89 commented 1 year ago

Thanks for this catch :) It is a duplication any way I should test it.