search

NETWAYS / ansible-collection-elasticstack

A collection to install and manage the Elastic Stack
GNU General Public License v3.0
9 stars 8 forks source link

Rename variables to keep naming scheme #160

Closed widhalmt closed 1 year ago

widhalmt commented 1 year ago

fixes #159

widhalmt commented 1 year ago

I made this a draft because there are still some variables missing in the renaming. We'll discuss how to proceed with them in #159

widhalmt commented 1 year ago

We opened a discussion around that issue upstream: https://github.com/ansible/ansible-lint/discussions/3451

To move fast, we now put this on the warn_list and come back to it, when the discussion is resolved. Hopefully to remove the rule completly from ansible-lint.yml.

widhalmt commented 1 year ago

@dgoetz I hope, I now caught all of the missing variables. Honestly, I feel a slight hint of panic when I think of merging this PR and all the others that are still open. 😱

widhalmt commented 1 year ago

Some of the checks are failing because of timeouts. As long as all lint checks and the required checks work, we should be safe.

afeefghannam89 commented 1 year ago

@widhalmt woo It is a big type work ✍️ Thanks I see the PR is ok. The only suggestion is the above, there are three stack words in the variable name. You can take the suggestion or ignore it.

widhalmt commented 1 year ago

Some of them aren't in alphabetical order on purpose. I tried to group them logically. :-)