Closed afeefghannam89 closed 1 year ago
Good idea! But this means, we need to change branch protection. If we don't have the full stack tests running before merging into main
we can't have these checks as a prerequisite for merging. Like this PR shows, you can't merge because the checks aren't running. But not running is exactly what this branch is about.
On the other hand, that means, we need to decide which checks are required
for every merge and which are just informational.
Good idea! But this means, we need to change branch protection. If we don't have the full stack tests running before merging into
main
we can't have these checks as a prerequisite for merging. Like this PR shows, you can't merge because the checks aren't running. But not running is exactly what this branch is about.On the other hand, that means, we need to decide which checks are
required
for every merge and which are just informational.
@widhalmt you are right big part of the implementation is done in another PR, I would test some scenarios here, to see what is better for us, then I will share you the results :)
We can run this very big pipeline before release manually on a specific branch e.g. main. When we get error we can fix it in another branch and then merge in main. The benefit from this:
test_role_pr
workflow then ontest_full_stack
to see if our fix work or not, when we have problem in thetest_full_stack
. The waiting time is about 3.5 hours. Now we can comment out all container, where our code worked, then test fixes on not working containers and run the CI/CD manually until we get every thing fixed.