NETWAYS / ansible-collection-elasticstack

A collection to install and manage the Elastic Stack
GNU General Public License v3.0
9 stars 8 forks source link

Reduce pipelines #171

Closed afeefghannam89 closed 1 year ago

afeefghannam89 commented 1 year ago

We can run this very big pipeline before release manually on a specific branch e.g. main. When we get error we can fix it in another branch and then merge in main. The benefit from this:

widhalmt commented 1 year ago

Good idea! But this means, we need to change branch protection. If we don't have the full stack tests running before merging into main we can't have these checks as a prerequisite for merging. Like this PR shows, you can't merge because the checks aren't running. But not running is exactly what this branch is about.

On the other hand, that means, we need to decide which checks are required for every merge and which are just informational.

afeefghannam89 commented 1 year ago

Good idea! But this means, we need to change branch protection. If we don't have the full stack tests running before merging into main we can't have these checks as a prerequisite for merging. Like this PR shows, you can't merge because the checks aren't running. But not running is exactly what this branch is about.

On the other hand, that means, we need to decide which checks are required for every merge and which are just informational.

@widhalmt you are right big part of the implementation is done in another PR, I would test some scenarios here, to see what is better for us, then I will share you the results :)