search

NETWAYS / ansible-collection-elasticstack

A collection to install and manage the Elastic Stack
GNU General Public License v3.0
9 stars 8 forks source link

Merge or squeeze logstash CI/CD pipelines #172

Open afeefghannam89 opened 1 year ago

afeefghannam89 commented 1 year ago

I think we can merge logstash_defualt and logstash_pipeline to one CI/CD pipeline. I think that the installation of logstash as standalone and testing his pipelines in one step will reduce the CI/CD running time and achieve two goals at once.

I am not sure if we can merge logstash_run_logstash with another CI/CD pipelines.

@widhalmt what do you think?

widhalmt commented 1 year ago

Good idea. I wanted to have both separated to test the role with as many defaults as possible. To show that the collection has a very low entry threshold. But since we have to set some variables nonetheless we can just merge one or both, too.

logstash_run_logstash was mostly introduced to check whether Logstash would start or not. So that we could have other pipelines without starting Logstash thus being faster. But I guess, that also lost its use now we change so much.

So yes, from my side, go ahead and merge them.