Closed widhalmt closed 10 months ago
Looks like the current version of Molecule lacks the docker driver.
It seems like we need to merge #182 before continuing with this.
Looks like tests are failing due to long running being "too long running"
Didn't we fix the tests? Can we merge main?
I thought the tests were fixed. :-( As much as I see, tests are still timing out. I don't want to remove the thorough tests we built so far. So I made tests "non mandatory" and check them manually. While this is ultra cumbersome I guess it's the best solution we have so far. Even more so as @martialblog said, we'll have our own GitHub runners soon. And then we'll definitely want our checks back.
So please see the checks "more like guidelines, anyway" and approve if the code makes sense. Even when some checks time out.
I found this line https://github.com/NETWAYS/ansible-collection-elasticstack/pull/240/files#diff-85634248b446d8a9a40ae7b3fca510c581832cbc85200a147c0fd9faea85d5d2R30 in a role by @geerlingguy . Sometimes the best solution can be so easy. You just have to think of it. 🤦🏽
Thanks so much @dnssmr I guess, I'll take a while before I adapted my old brain to this new style of coding. 🤦🏽
I hope, I caught all of them, now.
I converted this to da draft because the tests found some error that's not just due to problems in GitHub runners. I'll investigate locally and then come back. On the other hand... that's out of the scope of this PR, so I'll disable Draft status. 🤦🏽
We need #279 merged for this to work and be merged.
Run an apt refresh at the start of each role. We can use grace time so we don't neet to refresh it every time and safe some time.
fixes #167