Enhancement pipelines - Githubissues

NETWAYS / ansible-collection-elasticstack

A collection to install and manage the Elastic Stack

GNU General Public License v3.0

9 stars 8 forks source link

Enhancement pipelines #190

Closed afeefghannam89 closed 11 months ago

afeefghannam89 commented 1 year ago

Restrict the pull request workflow, fix #180
Use python 3.8 in Logstash pipeline, fix #189
Only run pr workflow while opening a pull request, but not in merge queue #193
Merge or squeeze logstash CI/CD pipelines #172
Fix full stack workflow on all containers #194

widhalmt commented 1 year ago

I see parallel checks. Won't that lead to collisions where different instances could run in the same container and so break a run?

afeefghannam89 commented 1 year ago

I see parallel checks. Won't that lead to collisions where different instances could run in the same container and so break a run?

N, I do not think so. Every instance will run separately. Did you see under the GitHub action history?

widhalmt commented 1 year ago

No, I didn't see it now. It just occured to me, that in some tests I had the same test breaking on different stages for no apparent reason. On closer analysis I found out that another Ansible run was changing things the current test just made. Thus it became apparent that several tests were using the same container.

But I have to admit, this happened long back and might not be an issue at all in current setups.

The easy solution, just renaming the containers in molecule.yml doesn't work if you run the same test with different variables from a matrix.

afeefghannam89 commented 1 year ago

According to the schema of the pipelines in this collection. Every instance will run on a container in an isolated pipeline. Only if we have cluster scenario, tow instance will run on two containers and communicate with each other, no one will impact or interfere in the other.