NETWAYS / ansible-collection-elasticstack

A collection to install and manage the Elastic Stack
GNU General Public License v3.0
10 stars 8 forks source link

Fix/lint workflow 192 #199

Closed Donien closed 1 year ago

Donien commented 1 year ago

Fix #192.

This PR introduces a reusable workflow. This general workflow handles the job necessary to run both ansible-lint and yamllint on either all roles or one specific role.

All roles are linted when:

Specific roles are linted when:

The workflow for the specific role now uses a call to the general linting workflow, while providing it with its own role name.

This approach does not completely remove linting from single workflows, but it makes those linting jobs much more readable and reduces redundant code, while also allowing for a bit more flexibility.

widhalmt commented 1 year ago

Nice! That seems like it could really help a lot with development.

widhalmt commented 1 year ago

We now have merged some major changes to the testing configuration. Could you please resolve the conflicts and have another look?

Donien commented 1 year ago

I've looked through the workflows again and made some changes.
This still needs a review. But as of today it should be compatible with the current main branch.