search

NETWAYS / ansible-collection-elasticstack

A collection to install and manage the Elastic Stack
GNU General Public License v3.0
10 stars 8 forks source link

Install cryptography Python library #213

Closed widhalmt closed 1 year ago

widhalmt commented 1 year ago

We had this as a requirement. But it makes sense to have the role install the library without any further interaction with the user.

fixes #212

widhalmt commented 1 year ago

It looks like the package is still named something else in Ubuntu systems. To be honest, I don't know how to proceed. It feels like the package is named differently across all supported OSes. And forcing to use pip doesn't feel right, either.

Has anyone of you a better idea?

danopt commented 1 year ago

Hmm, I checked it on different OS. As far as I can see, all newer OS use python3 and the package is available under python3-cryptography. The only one I know where python-cryptography >= 2.5 is not available within the system package manager is CentOS 7. There we will need to install it with pip.

That should be convention after PEP 394 and most distributions following this recommendation except for Windows. (https://stackoverflow.com/questions/62214293/is-python3-always-installed-with-python-3)

I double checked it on these OS: Rockylinux 8 Python 3.6.8 (default, Jun 22 2023, 05:10:43) python3-cryptography

Debian 11 Python 3.9.2 (default, Feb 28 2021, 17:03:44) python3-cryptography

Ubuntu 20.04 Python 3.8.10 (default, May 26 2023, 14:05:08) python3-cryptography

Ubuntu 22.04 Python 3.10.12 (main, Jun 11 2023, 05:26:28) [GCC 11.4.0] on linux python3-cryptography

For older systems the user can change the package to python-cryptography instead of python3-cryptography or/and we could offer an alternative installation with pip. The installation hasn't to be system-wide if we give pip the --user parameter for installation.

Am I missing something?

widhalmt commented 1 year ago

I guess, you're right. I'm just living in the past.... I go for python3-cryptography then.

widhalmt commented 1 year ago

I'll wait for #179 and #243 to be merged before resolving these conflicts. This should give us working tests. Finally.

widhalmt commented 1 year ago

Looks like repositories of Rocky Linux are facing some issues right now. I'll try later and rerun the failing tests.