search

NETWAYS / ansible-collection-elasticstack

A collection to install and manage the Elastic Stack
GNU General Public License v3.0
9 stars 8 forks source link

make elasticsearch network.host configurable #220

Closed xtruthx closed 10 months ago

xtruthx commented 11 months ago

This PR fixes #219

xtruthx commented 11 months ago

Sorry, I had to change back to "Request changes". Could you please write a line about the new variable in the appropriate file in docs/?

I will avoid doiing duplicate work. This will be done within the PR for the documentation review. Pls accept the PR without additionl docs, anyway if you not set it the "legacy" default will take precedence.

xtruthx commented 11 months ago

the fix of #217 conflicts :/

lcndsmr commented 11 months ago

Its just a renaming of variables, you should just replace the names and it should work. I can do it quickly if you want to?

xtruthx commented 11 months ago

Its just a renaming of variables, you should just replace the names and it should work. I can do it quickly if you want to?

thx, its already done.

xtruthx commented 11 months ago

Sorry, I have to revert my approval. I thought a lot about how the collection is proceeding and I'm afraid we have to face the fact that we aren't full time developers andtherefore we can be sure that we run into times where changes will have to wait for a long time. (You had to experience that for yourself). So the only way to not lose focus and have all neccessary steps done right away is to make changes atomic. Therefore I opened an issue to force documentation with every step: #234 .

So please add documentation for that variable with this PR.

I've add a description to the documenation.