Closed widhalmt closed 1 year ago
We need to undo a change from https://github.com/NETWAYS/ansible-collection-elasticstack/pull/223/files#diff-b29f4d48916b7c25995853ea04ea35f909f293e5ae32ecc648e19c8f80e3ff40R21-R27 .
I have to admit that I approved of these changes. I thought, these are some pre-tasks for changes to come, but honestly, there's no need for the else. We have a reasonable default in https://github.com/NETWAYS/ansible-collection-elasticstack/blob/main/roles/elasticsearch/defaults/main.yml#L17 so there isn't a situation where elasticsearch_heap could not be set. And still you can set it manually if you need.
else
elasticsearch_heap
While every code will get bloated over time, I really want this code to be cleaned up because a typo in it just gave me a really hard time.
We need to undo a change from https://github.com/NETWAYS/ansible-collection-elasticstack/pull/223/files#diff-b29f4d48916b7c25995853ea04ea35f909f293e5ae32ecc648e19c8f80e3ff40R21-R27 .
I have to admit that I approved of these changes. I thought, these are some pre-tasks for changes to come, but honestly, there's no need for the
else. We have a reasonable default in https://github.com/NETWAYS/ansible-collection-elasticstack/blob/main/roles/elasticsearch/defaults/main.yml#L17 so there isn't a situation whereelasticsearch_heapcould not be set. And still you can set it manually if you need.While every code will get bloated over time, I really want this code to be cleaned up because a typo in it just gave me a really hard time.