search

NETWAYS / ansible-collection-elasticstack

A collection to install and manage the Elastic Stack
GNU General Public License v3.0
10 stars 8 forks source link

Use common variable for TLS #274

Open widhalmt opened 1 year ago

widhalmt commented 1 year ago

fixes #248

The metricbeat.yml and auditbeat.yml templates have code for both connecting to Logstash or Elasticseach. They used different variables to determine whether to turn on TLS or not. That resulted in a missing default and therefore Beats setup breaking when connecting to Elasticseach. I changed the variable that's queried to determine whether to turn on TLS or not.

This is something between a workaround and a partial solution. While it makes more sense to use a role related variable for both Logstash and Elasticsearch output (other than before) it's still not the goal we want.

So overhauling the whole process of determining whether we need TLS or not is due. I'll start a discussion and we need to adjust all roles to the solution we find. Now there are similarities but it's not exactly the same in every role.

lcndsmr commented 1 year ago

Is the documentation still valid with these changes?

widhalmt commented 1 year ago

... I hope, I didn't miss anything. But I'll have a second look.

danopt commented 1 year ago

@widhalmt Can I push documentation for elasticsearch_http_security and elasticsearch_http_protocol to this PR. I can check and add documentation for beats_security, if required, too.

widhalmt commented 1 year ago

@DanOPT of course! Go ahead.

lcndsmr commented 11 months ago

Whats going on here? Can i merge main? Are you still working on changes?

widhalmt commented 8 months ago

@lcndsmr sorry for the eternal wait... yes, the documentation already has the new variables. So this fix actually makes code matching the docs better.

widhalmt commented 7 months ago

@lcndsmr could you recheck?