NETWAYS / ansible-collection-elasticstack

A collection to install and manage the Elastic Stack
GNU General Public License v3.0
9 stars 8 forks source link

elasticsearch_tls_key_passphrase containing $ not working #282

Open ivareri opened 8 months ago

ivareri commented 8 months ago

elasticsearch_tls_key_passphrase with a $ character is not working. This is most likely due to using echo with " quotation. This will lead to parameter expansion, while using ' wont.

~ >>> echo "test$var@test"                                                                                                                                                                
test@test

vs

~ >>> echo 'test$var@test'                                                                                                                                                                
test$var@test

This is done several places in elasticsearch-keystore.yml, like here

widhalmt commented 8 months ago

Good catch! Thank you. I'll look into it. I guess, I'll work it into a test case and then fix it.

widhalmt commented 8 months ago

I submitted a draft of a pull request with your suggested solution. Unfortunately it seems, that's not enough to fix the problem. I'll keep investigating. Please follow the PR and if you have anything to add, feel free to do there.