search

NETWAYS / ansible-collection-elasticstack

A collection to install and manage the Elastic Stack
GNU General Public License v3.0
9 stars 8 forks source link

Should we introduce an extra role for collection wide variables? #286

Closed widhalmt closed 2 months ago

widhalmt commented 8 months ago

Like in https://stackoverflow.com/questions/67213727/ansible-collections-collection-level-variable we could build a role called elasticstack. This will only hold defaults/main.yml and README.md. All variables we use in all roles could be set there. So we had them in a central place to change and document. And we could get rid of those pesky linter messages about variable names not matching role names.

ivareri commented 8 months ago

My first thought was that you meant a new repo with just a single role, but you're thinking of an extra role in this repo?

I do think this seems like a clean solution. As long as it is the same repo it shouldn't add any extra burden on contributors and reviewers.

widhalmt commented 5 months ago

Yes, I'm thinking of a role in this very repo. Like roles/elasticstack . And have all "global" variables in there.